[libvirt PATCH 00/10] virHashNew refactorings - part IV

Tim Wiederhake posted 10 patches 2 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210713144441.60635-1-twiederh@redhat.com
src/conf/domain_nwfilter.c             | 15 ++++-----------
src/conf/virnwfilterbindingdef.c       | 15 ++++-----------
src/conf/virnwfilterbindingdef.h       |  2 ++
src/conf/virnwfilterbindingobjlist.c   |  5 +----
src/nwfilter/nwfilter_dhcpsnoop.c      | 17 -----------------
src/nwfilter/nwfilter_gentech_driver.c |  3 +--
6 files changed, 12 insertions(+), 45 deletions(-)
[libvirt PATCH 00/10] virHashNew refactorings - part IV
Posted by Tim Wiederhake 2 years, 9 months ago
"virHashNew" cannot return NULL, yet we check for NULL in various places.

See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.

Tim Wiederhake (10):
  conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterBindingDef
  virNWFilterBindingDefCopy: `virHashNew` cannot return NULL
  virNWFilterBindingDefCopy: Use automatic memory management
  virNWFilterBindingDefCopy: Remove superfluous `goto`s
  virNWFilterBindingDefForNet: `virHashNew` cannot return NULL
  virNWFilterBindingDefForNet: Use automatic memory management
  virNWFilterBindingDefForNet: Remove superfluous `goto`s
  virNWFilterBindingObjListNew: `virHashNew` cannot return NULL
  virNWFilterBuildAll: `virHashNew` cannot return NULL
  virNWFilterDHCPSnoopInit: `virHashNew` cannot return NULL

 src/conf/domain_nwfilter.c             | 15 ++++-----------
 src/conf/virnwfilterbindingdef.c       | 15 ++++-----------
 src/conf/virnwfilterbindingdef.h       |  2 ++
 src/conf/virnwfilterbindingobjlist.c   |  5 +----
 src/nwfilter/nwfilter_dhcpsnoop.c      | 17 -----------------
 src/nwfilter/nwfilter_gentech_driver.c |  3 +--
 6 files changed, 12 insertions(+), 45 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 00/10] virHashNew refactorings - part IV
Posted by Peter Krempa 2 years, 9 months ago
On Tue, Jul 13, 2021 at 16:44:31 +0200, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various places.
> 
> See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.
> 
> Tim Wiederhake (10):
>   conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterBindingDef
>   virNWFilterBindingDefCopy: `virHashNew` cannot return NULL
>   virNWFilterBindingDefCopy: Use automatic memory management
>   virNWFilterBindingDefCopy: Remove superfluous `goto`s
>   virNWFilterBindingDefForNet: `virHashNew` cannot return NULL
>   virNWFilterBindingDefForNet: Use automatic memory management
>   virNWFilterBindingDefForNet: Remove superfluous `goto`s
>   virNWFilterBindingObjListNew: `virHashNew` cannot return NULL
>   virNWFilterBuildAll: `virHashNew` cannot return NULL
>   virNWFilterDHCPSnoopInit: `virHashNew` cannot return NULL

Series:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>