[libvirt PATCH 0/5] qemu: Fix defaults for TPM on ARM virt guests

Andrea Bolognani posted 5 patches 2 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210625142745.117287-1-abologna@redhat.com
docs/formatdomain.rst                         |  9 ++++--
src/qemu/qemu_domain.c                        |  3 +-
src/qemu/qemu_validate.c                      |  6 ++++
.../aarch64-tpm-wrong-model.err               |  1 +
...64-tpm.xml => aarch64-tpm-wrong-model.xml} |  2 +-
tests/qemuxml2argvdata/aarch64-tpm.xml        |  4 +--
tests/qemuxml2argvtest.c                      |  1 +
.../aarch64-tpm.aarch64-latest.xml            | 29 +++++++++++++++++++
tests/qemuxml2xmltest.c                       |  1 +
9 files changed, 49 insertions(+), 7 deletions(-)
create mode 100644 tests/qemuxml2argvdata/aarch64-tpm-wrong-model.err
copy tests/qemuxml2argvdata/{aarch64-tpm.xml => aarch64-tpm-wrong-model.xml} (88%)
create mode 100644 tests/qemuxml2xmloutdata/aarch64-tpm.aarch64-latest.xml
[libvirt PATCH 0/5] qemu: Fix defaults for TPM on ARM virt guests
Posted by Andrea Bolognani 2 years, 9 months ago
The current default is unfortunately broken, and the user has to
manually step in and provide the version number explicitly for the
TPM device to work at all.

https://bugzilla.redhat.com/show_bug.cgi?id=1970310

Andrea Bolognani (5):
  docs: Fix information for default TPM version
  tests: Add aarch64-tpm test to qemuxml2xml
  qemu: Default to TPM 2.0 for ARM virt guests
  tests: Test the defaults for TPM on ARM virt guests
  qemu: Reject TPM 1.2 for ARM virt guests

 docs/formatdomain.rst                         |  9 ++++--
 src/qemu/qemu_domain.c                        |  3 +-
 src/qemu/qemu_validate.c                      |  6 ++++
 .../aarch64-tpm-wrong-model.err               |  1 +
 ...64-tpm.xml => aarch64-tpm-wrong-model.xml} |  2 +-
 tests/qemuxml2argvdata/aarch64-tpm.xml        |  4 +--
 tests/qemuxml2argvtest.c                      |  1 +
 .../aarch64-tpm.aarch64-latest.xml            | 29 +++++++++++++++++++
 tests/qemuxml2xmltest.c                       |  1 +
 9 files changed, 49 insertions(+), 7 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/aarch64-tpm-wrong-model.err
 copy tests/qemuxml2argvdata/{aarch64-tpm.xml => aarch64-tpm-wrong-model.xml} (88%)
 create mode 100644 tests/qemuxml2xmloutdata/aarch64-tpm.aarch64-latest.xml

-- 
2.31.1


Re: [libvirt PATCH 0/5] qemu: Fix defaults for TPM on ARM virt guests
Posted by Michal Prívozník 2 years, 9 months ago
On 6/25/21 4:27 PM, Andrea Bolognani wrote:
> The current default is unfortunately broken, and the user has to
> manually step in and provide the version number explicitly for the
> TPM device to work at all.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1970310
> 
> Andrea Bolognani (5):
>   docs: Fix information for default TPM version
>   tests: Add aarch64-tpm test to qemuxml2xml
>   qemu: Default to TPM 2.0 for ARM virt guests
>   tests: Test the defaults for TPM on ARM virt guests
>   qemu: Reject TPM 1.2 for ARM virt guests
> 
>  docs/formatdomain.rst                         |  9 ++++--
>  src/qemu/qemu_domain.c                        |  3 +-
>  src/qemu/qemu_validate.c                      |  6 ++++
>  .../aarch64-tpm-wrong-model.err               |  1 +
>  ...64-tpm.xml => aarch64-tpm-wrong-model.xml} |  2 +-
>  tests/qemuxml2argvdata/aarch64-tpm.xml        |  4 +--
>  tests/qemuxml2argvtest.c                      |  1 +
>  .../aarch64-tpm.aarch64-latest.xml            | 29 +++++++++++++++++++
>  tests/qemuxml2xmltest.c                       |  1 +
>  9 files changed, 49 insertions(+), 7 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/aarch64-tpm-wrong-model.err
>  copy tests/qemuxml2argvdata/{aarch64-tpm.xml => aarch64-tpm-wrong-model.xml} (88%)
>  create mode 100644 tests/qemuxml2xmloutdata/aarch64-tpm.aarch64-latest.xml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal