On 6/30/21 3:56 PM, Jonathon Jongsma wrote:
> On Wed, Jun 30, 2021 at 3:18 AM Michal Prívozník <mprivozn@redhat.com> wrote:
>>
>> On 6/22/21 9:53 PM, Jonathon Jongsma wrote:
>>> A few minor fixes to mdev support in the nodedev driver
>>>
>>> Changes in v2:
>>> - split out the error-reporting macro into a separate commit as recommended by Peter
>>> - Since virCommandRun() may report an error, ensure that the
>>> virMdevctl$COMMAND() functions always set an error to make error-handling
>>> consistent. v1 tried to return an error message and have the caller report
>>> the error.
>>> - Added a new patch (destroying inactive device)
>>>
>>> Jonathon Jongsma (5):
>>> nodedev: Remove useless device name from error message
>>> nodedev: Handle NULL command variable
>>> nodedev: add macro to handle command errors
>>> nodedev: handle mdevctl errors consistently
>>> nodedev: improve error message when destroying an inactive device
>>>
>>> src/node_device/node_device_driver.c | 147 +++++++++++++++++----------
>>> 1 file changed, 94 insertions(+), 53 deletions(-)
>>>
>>
>> I'm sorry for not picking this earlier up. We are pretty close to the
>> release (which is supposed to happen tomorrow). Are you okay with me
>> waiting one more day and push this after the release?
>>
>> Michal
>>
>
> These are fairly minor fixes so it doesn't really matter if they wait
> for the next release. The one that I was hoping would get into a
> release sooner is this one:
> https://listman.redhat.com/archives/libvir-list/2021-June/msg00271.html
>
Pushed now.
Michal