[libvirt PATCH 00/16] Refactor virDomainFeaturesDefParse

Tim Wiederhake posted 16 patches 2 years, 10 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210622122257.12528-1-twiederh@redhat.com
src/conf/domain_conf.c | 557 ++++++++++++++++++++++-------------------
1 file changed, 296 insertions(+), 261 deletions(-)
[libvirt PATCH 00/16] Refactor virDomainFeaturesDefParse
Posted by Tim Wiederhake 2 years, 10 months ago
Some refactoring in preparation for adding support for qemu's
"hv-passthrough" and the yet-to-be-merged "hv-defaults".

Tim Wiederhake (16):
  virDomainFeaturesDefParse: Factor out HyperV parsing into separate
    function
  virDomainFeaturesHyperVDefParse: Inline hyperv/stimer parsing
  virDomainFeaturesHyperVDefParse: Remove ctxt
  virDomainFeaturesHyperVDefParse: Remove tautological "if"
  virDomainFeaturesDefParse: Factor out KVM parsing into separate
    function
  virDomainFeaturesKVMDefParse: Remove ctxt
  virDomainFeaturesKVMDefParse: Remove tautological "switch"
  virDomainFeaturesKVMDefParse: Remove tautological "if"
  virDomainFeaturesDefParse: Factor out XEN parsing into separate
    function
  virDomainFeaturesXENDefParse: Remove ctxt
  virDomainFeaturesXENDefParse: Remove tautological "if"
  virDomainFeaturesDefParse: Inline SMM parsing
  virDomainFeaturesDefParse: Inline MSRS parsing
  virDomainFeaturesDefParse: Factor out capabilities parsing into
    separate function
  virDomainFeaturesCapabilitiesDefParse: Remove ctxt
  virDomainFeaturesDefParse: Simplify APIC parsing

 src/conf/domain_conf.c | 557 ++++++++++++++++++++++-------------------
 1 file changed, 296 insertions(+), 261 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 00/16] Refactor virDomainFeaturesDefParse
Posted by Michal Prívozník 2 years, 10 months ago
On 6/22/21 2:22 PM, Tim Wiederhake wrote:
> Some refactoring in preparation for adding support for qemu's
> "hv-passthrough" and the yet-to-be-merged "hv-defaults".
> 
> Tim Wiederhake (16):
>   virDomainFeaturesDefParse: Factor out HyperV parsing into separate
>     function
>   virDomainFeaturesHyperVDefParse: Inline hyperv/stimer parsing
>   virDomainFeaturesHyperVDefParse: Remove ctxt
>   virDomainFeaturesHyperVDefParse: Remove tautological "if"
>   virDomainFeaturesDefParse: Factor out KVM parsing into separate
>     function
>   virDomainFeaturesKVMDefParse: Remove ctxt
>   virDomainFeaturesKVMDefParse: Remove tautological "switch"
>   virDomainFeaturesKVMDefParse: Remove tautological "if"
>   virDomainFeaturesDefParse: Factor out XEN parsing into separate
>     function
>   virDomainFeaturesXENDefParse: Remove ctxt
>   virDomainFeaturesXENDefParse: Remove tautological "if"
>   virDomainFeaturesDefParse: Inline SMM parsing
>   virDomainFeaturesDefParse: Inline MSRS parsing
>   virDomainFeaturesDefParse: Factor out capabilities parsing into
>     separate function
>   virDomainFeaturesCapabilitiesDefParse: Remove ctxt
>   virDomainFeaturesDefParse: Simplify APIC parsing
> 
>  src/conf/domain_conf.c | 557 ++++++++++++++++++++++-------------------
>  1 file changed, 296 insertions(+), 261 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal