[PATCH 0/2] Xen: Fallout from minimum supported version bump

Jim Fehlig posted 2 patches 2 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210617203029.8893-1-jfehlig@suse.com
Test syntax-check failed
NEWS.rst                       |  7 ++++++
src/libxl/libxl_capabilities.c | 14 ++---------
src/libxl/libxl_capabilities.h |  2 --
src/libxl/libxl_conf.c         | 45 ----------------------------------
src/libxl/libxl_domain.c       | 20 +--------------
src/libxl/libxl_driver.c       | 29 +---------------------
src/libxl/xen_xl.c             | 24 ++----------------
tests/domaincapsmock.c         | 11 ---------
tests/libxlxml2domconfigtest.c |  6 -----
tests/xlconfigtest.c           | 12 ---------
10 files changed, 13 insertions(+), 157 deletions(-)
[PATCH 0/2] Xen: Fallout from minimum supported version bump
Posted by Jim Fehlig 2 years, 10 months ago
Patch 1 removes the use of LIBXL_HAVE_* that are present in Xen >= 4.9.
Patch 2 mentions the version bump in News.

Thanks danpb for a little prodding to take a closer look at potential
code reduction! After following through with the exersice, it proved
to be a bit more than I expected.

Jim Fehlig (2):
  Xen: Remove unneeded LIBXL_HAVE_* ifdefs
  News: Mention bump in minimum supported Xen version

 NEWS.rst                       |  7 ++++++
 src/libxl/libxl_capabilities.c | 14 ++---------
 src/libxl/libxl_capabilities.h |  2 --
 src/libxl/libxl_conf.c         | 45 ----------------------------------
 src/libxl/libxl_domain.c       | 20 +--------------
 src/libxl/libxl_driver.c       | 29 +---------------------
 src/libxl/xen_xl.c             | 24 ++----------------
 tests/domaincapsmock.c         | 11 ---------
 tests/libxlxml2domconfigtest.c |  6 -----
 tests/xlconfigtest.c           | 12 ---------
 10 files changed, 13 insertions(+), 157 deletions(-)

-- 
2.31.1


Re: [PATCH 0/2] Xen: Fallout from minimum supported version bump
Posted by Daniel P. Berrangé 2 years, 10 months ago
On Thu, Jun 17, 2021 at 02:30:27PM -0600, Jim Fehlig wrote:
> Patch 1 removes the use of LIBXL_HAVE_* that are present in Xen >= 4.9.
> Patch 2 mentions the version bump in News.
> 
> Thanks danpb for a little prodding to take a closer look at potential
> code reduction! After following through with the exersice, it proved
> to be a bit more than I expected.
> 
> Jim Fehlig (2):
>   Xen: Remove unneeded LIBXL_HAVE_* ifdefs
>   News: Mention bump in minimum supported Xen version

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 0/2] Xen: Fallout from minimum supported version bump
Posted by Olaf Hering 2 years, 10 months ago
Am Thu, 17 Jun 2021 14:30:27 -0600
schrieb Jim Fehlig <jfehlig@suse.com>:

> Patch 1 removes the use of LIBXL_HAVE_* that are present in Xen >= 4.9.

Thanks, this compiles for, and looks good to me.

Olaf