[PATCH] docs: add a link to Gitlab on the contributing page

Simon Chopin posted 1 patch 2 years, 10 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210614082350.14796-1-chopin.simon@gmail.com
docs/contribute.html.in | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
[PATCH] docs: add a link to Gitlab on the contributing page
Posted by Simon Chopin 2 years, 10 months ago
I expect to find a link to the repositories when clicking on
"Contribute", this patch fixes this. The wording is directly inspired by
the one on the hacking page.

Signed-off-by: Simon Chopin <chopin.simon@gmail.com>
---
 docs/contribute.html.in | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/docs/contribute.html.in b/docs/contribute.html.in
index d2001053fc..790114a56d 100644
--- a/docs/contribute.html.in
+++ b/docs/contribute.html.in
@@ -31,9 +31,10 @@
     </p>
 
     <ul>
-      <li><strong>Software development</strong>. The core library / daemon (and
-        thus the bulk of coding) is written in C, but there are
-        language bindings written in Python, Perl, Java, Ruby,
+      <li><strong>Software development</strong>. The official upstream code are
+        kept in various <a href="https://gitlab.com/libvirt/">Git repositories</a>.
+        The core library / daemon (and thus the bulk of coding) is written in C,
+        but there are language bindings written in Python, Perl, Java, Ruby,
         Php, OCaml and Go. There are also higher level wrappers
         mapping libvirt into other object frameworks, such GLib,
         CIM and SNMP. For those interested in working on the core parts of

base-commit: 55ea45acc99c549c7757efe954aacc33ad30a8ef
-- 
2.32.0

Re: [PATCH] docs: add a link to Gitlab on the contributing page
Posted by Jano Tomko 2 years, 10 months ago
On 6/14/21 10:23 AM, Simon Chopin wrote:
> I expect to find a link to the repositories when clicking on
> "Contribute", this patch fixes this. The wording is directly inspired by
> the one on the hacking page.
> 
> Signed-off-by: Simon Chopin <chopin.simon@gmail.com>
> ---
>  docs/contribute.html.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/contribute.html.in b/docs/contribute.html.in
> index d2001053fc..790114a56d 100644
> --- a/docs/contribute.html.in
> +++ b/docs/contribute.html.in
> @@ -31,9 +31,10 @@
>      </p>
>  
>      <ul>
> -      <li><strong>Software development</strong>. The core library / daemon (and
> -        thus the bulk of coding) is written in C, but there are
> -        language bindings written in Python, Perl, Java, Ruby,
> +      <li><strong>Software development</strong>. The official upstream code are
> +        kept in various <a href="https://gitlab.com/libvirt/">Git repositories</a>.
> +        The core library / daemon (and thus the bulk of coding) is written in C,
> +        but there are language bindings written in Python, Perl, Java, Ruby,
>          Php, OCaml and Go. There are also higher level wrappers
>          mapping libvirt into other object frameworks, such GLib,
>          CIM and SNMP. For those interested in working on the core parts of
> 
> base-commit: 55ea45acc99c549c7757efe954aacc33ad30a8ef
> 

Reviewed-by: Ján Tomko <jtomko@redhat.com>

and pushed now

Jano