[PATCH 0/3] libxl: A few firmware improvments

Jim Fehlig posted 3 patches 2 years, 10 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210604172748.681-1-jfehlig@suse.com
src/libxl/libxl_conf.c   | 17 ++++++++++++--
src/libxl/libxl_domain.c | 49 ++++++++++++++++++++++++++++++++--------
2 files changed, 54 insertions(+), 12 deletions(-)
[PATCH 0/3] libxl: A few firmware improvments
Posted by Jim Fehlig 2 years, 10 months ago
Upstream ovmf will be removing support for Xen in the traditional ovmf
package, moving it to a separate OvmfXen package

https://bugzilla.tianocore.org/show_bug.cgi?id=2122

This motivated me to verify the impact on libvirt+ovmf+xen. Fortunately it
is minimal since the new OvmfXen package is basically a reduced version of
the traditional package. I.e. it should contain everything the traditional
package contains and thus is binary compatible and should not affect
existing guests using the traditional package. Indeed my initial testing
has shown this to be true.

While testing I cooked up a few improvements to the libxl driver firmware
handling, including adding support for automatic firmware selection.

Thanks for review/comments!

Jim Fehlig (3):
  libxl: Introduce domain def validate callback
  libxl: Forbid domain definition with secure boot enabled
  libxl: Support firmware autoselection

 src/libxl/libxl_conf.c   | 17 ++++++++++++--
 src/libxl/libxl_domain.c | 49 ++++++++++++++++++++++++++++++++--------
 2 files changed, 54 insertions(+), 12 deletions(-)

-- 
2.31.1


Re: [PATCH 0/3] libxl: A few firmware improvments
Posted by Michal Prívozník 2 years, 10 months ago
On 6/4/21 7:27 PM, Jim Fehlig wrote:
> Upstream ovmf will be removing support for Xen in the traditional ovmf
> package, moving it to a separate OvmfXen package
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> 
> This motivated me to verify the impact on libvirt+ovmf+xen. Fortunately it
> is minimal since the new OvmfXen package is basically a reduced version of
> the traditional package. I.e. it should contain everything the traditional
> package contains and thus is binary compatible and should not affect
> existing guests using the traditional package. Indeed my initial testing
> has shown this to be true.
> 
> While testing I cooked up a few improvements to the libxl driver firmware
> handling, including adding support for automatic firmware selection.
> 
> Thanks for review/comments!
> 
> Jim Fehlig (3):
>   libxl: Introduce domain def validate callback
>   libxl: Forbid domain definition with secure boot enabled
>   libxl: Support firmware autoselection
> 
>  src/libxl/libxl_conf.c   | 17 ++++++++++++--
>  src/libxl/libxl_domain.c | 49 ++++++++++++++++++++++++++++++++--------
>  2 files changed, 54 insertions(+), 12 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal