[PATCH] remote: remove/annotate unused variables

Daniel P. Berrangé posted 1 patch 2 years, 10 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210604150725.156835-1-berrange@redhat.com
src/remote/remote_driver.c | 3 ---
src/rpc/virnetsocket.c     | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
[PATCH] remote: remove/annotate unused variables
Posted by Daniel P. Berrangé 2 years, 10 months ago
Fixes commit 48f66cfe3ee51baf64f06f1f89dda52af6f4d9d6
Fixes commit fcdcf8f70cf5d6657086e2889124d0e1a7332a29
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/remote/remote_driver.c | 3 ---
 src/rpc/virnetsocket.c     | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index da672b0d00..c03c68ec30 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -729,9 +729,6 @@ doRemoteOpen(virConnectPtr conn,
              virConf *conf,
              unsigned int flags)
 {
-#ifndef WIN32
-    g_autofree char *daemonPath = NULL;
-#endif
     g_autofree char *tls_priority = NULL;
     g_autofree char *name = NULL;
     g_autofree char *command = NULL;
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index c3fae8b626..212089520d 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
@@ -774,7 +774,7 @@ int virNetSocketNewConnectUNIX(const char *path,
 }
 #else
 int virNetSocketNewConnectUNIX(const char *path G_GNUC_UNUSED,
-                               const char *spawnDaemonPath,
+                               const char *spawnDaemonPath G_GNUC_UNUSED,
                                virNetSocket **retsock G_GNUC_UNUSED)
 {
     virReportSystemError(ENOSYS, "%s",
-- 
2.31.1

Re: [PATCH] remote: remove/annotate unused variables
Posted by Michal Prívozník 2 years, 10 months ago
On 6/4/21 5:07 PM, Daniel P. Berrangé wrote:
> Fixes commit 48f66cfe3ee51baf64f06f1f89dda52af6f4d9d6
> Fixes commit fcdcf8f70cf5d6657086e2889124d0e1a7332a29
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/remote/remote_driver.c | 3 ---
>  src/rpc/virnetsocket.c     | 2 +-
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index da672b0d00..c03c68ec30 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -729,9 +729,6 @@ doRemoteOpen(virConnectPtr conn,
>               virConf *conf,
>               unsigned int flags)
>  {
> -#ifndef WIN32
> -    g_autofree char *daemonPath = NULL;
> -#endif
>      g_autofree char *tls_priority = NULL;
>      g_autofree char *name = NULL;
>      g_autofree char *command = NULL;
> diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
> index c3fae8b626..212089520d 100644
> --- a/src/rpc/virnetsocket.c
> +++ b/src/rpc/virnetsocket.c
> @@ -774,7 +774,7 @@ int virNetSocketNewConnectUNIX(const char *path,
>  }
>  #else
>  int virNetSocketNewConnectUNIX(const char *path G_GNUC_UNUSED,
> -                               const char *spawnDaemonPath,
> +                               const char *spawnDaemonPath G_GNUC_UNUSED,
>                                 virNetSocket **retsock G_GNUC_UNUSED)
>  {
>      virReportSystemError(ENOSYS, "%s",
> 

Ouch, I've missed this completely and pushed the same patch. Sorry about
that.

Michal