[libvirt PATCH 0/2] Add missing audio timer period setting

Daniel P. Berrangé posted 2 patches 2 years, 10 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210603081843.470330-1-berrange@redhat.com
docs/formatdomain.rst                                     | 6 +++++-
docs/schemas/domaincommon.rng                             | 5 +++++
src/conf/domain_conf.c                                    | 7 +++++++
src/conf/domain_conf.h                                    | 2 ++
src/qemu/qemu_command.c                                   | 8 ++++++++
tests/qemuxml2argvdata/audio-alsa-best.args               | 1 +
tests/qemuxml2argvdata/audio-alsa-best.x86_64-latest.args | 2 +-
tests/qemuxml2argvdata/audio-alsa-best.xml                | 2 +-
tests/qemuxml2argvdata/audio-coreaudio-best.args          | 1 +
.../audio-coreaudio-best.x86_64-latest.args               | 2 +-
tests/qemuxml2argvdata/audio-coreaudio-best.xml           | 2 +-
tests/qemuxml2argvdata/audio-file-best.args               | 1 +
tests/qemuxml2argvdata/audio-file-best.x86_64-latest.args | 2 +-
tests/qemuxml2argvdata/audio-file-best.xml                | 2 +-
tests/qemuxml2argvdata/audio-none-best.args               | 1 +
tests/qemuxml2argvdata/audio-none-best.x86_64-latest.args | 2 +-
tests/qemuxml2argvdata/audio-none-best.xml                | 2 +-
tests/qemuxml2argvdata/audio-oss-best.args                | 1 +
tests/qemuxml2argvdata/audio-oss-best.x86_64-latest.args  | 2 +-
tests/qemuxml2argvdata/audio-oss-best.xml                 | 2 +-
tests/qemuxml2argvdata/audio-pulseaudio-best.args         | 1 +
.../audio-pulseaudio-best.x86_64-latest.args              | 2 +-
tests/qemuxml2argvdata/audio-pulseaudio-best.xml          | 2 +-
tests/qemuxml2argvdata/audio-sdl-best.args                | 1 +
tests/qemuxml2argvdata/audio-sdl-best.x86_64-latest.args  | 2 +-
tests/qemuxml2argvdata/audio-sdl-best.xml                 | 2 +-
tests/qemuxml2argvdata/audio-spice-best.args              | 1 +
.../qemuxml2argvdata/audio-spice-best.x86_64-latest.args  | 2 +-
tests/qemuxml2argvdata/audio-spice-best.xml               | 2 +-
29 files changed, 51 insertions(+), 17 deletions(-)
[libvirt PATCH 0/2] Add missing audio timer period setting
Posted by Daniel P. Berrangé 2 years, 10 months ago
Somehow I missed this one property during initial impl of audio

Daniel P. Berrangé (2):
  conf: add support for timer period audio setting
  qemu: wire up support for timer period audio setting

 docs/formatdomain.rst                                     | 6 +++++-
 docs/schemas/domaincommon.rng                             | 5 +++++
 src/conf/domain_conf.c                                    | 7 +++++++
 src/conf/domain_conf.h                                    | 2 ++
 src/qemu/qemu_command.c                                   | 8 ++++++++
 tests/qemuxml2argvdata/audio-alsa-best.args               | 1 +
 tests/qemuxml2argvdata/audio-alsa-best.x86_64-latest.args | 2 +-
 tests/qemuxml2argvdata/audio-alsa-best.xml                | 2 +-
 tests/qemuxml2argvdata/audio-coreaudio-best.args          | 1 +
 .../audio-coreaudio-best.x86_64-latest.args               | 2 +-
 tests/qemuxml2argvdata/audio-coreaudio-best.xml           | 2 +-
 tests/qemuxml2argvdata/audio-file-best.args               | 1 +
 tests/qemuxml2argvdata/audio-file-best.x86_64-latest.args | 2 +-
 tests/qemuxml2argvdata/audio-file-best.xml                | 2 +-
 tests/qemuxml2argvdata/audio-none-best.args               | 1 +
 tests/qemuxml2argvdata/audio-none-best.x86_64-latest.args | 2 +-
 tests/qemuxml2argvdata/audio-none-best.xml                | 2 +-
 tests/qemuxml2argvdata/audio-oss-best.args                | 1 +
 tests/qemuxml2argvdata/audio-oss-best.x86_64-latest.args  | 2 +-
 tests/qemuxml2argvdata/audio-oss-best.xml                 | 2 +-
 tests/qemuxml2argvdata/audio-pulseaudio-best.args         | 1 +
 .../audio-pulseaudio-best.x86_64-latest.args              | 2 +-
 tests/qemuxml2argvdata/audio-pulseaudio-best.xml          | 2 +-
 tests/qemuxml2argvdata/audio-sdl-best.args                | 1 +
 tests/qemuxml2argvdata/audio-sdl-best.x86_64-latest.args  | 2 +-
 tests/qemuxml2argvdata/audio-sdl-best.xml                 | 2 +-
 tests/qemuxml2argvdata/audio-spice-best.args              | 1 +
 .../qemuxml2argvdata/audio-spice-best.x86_64-latest.args  | 2 +-
 tests/qemuxml2argvdata/audio-spice-best.xml               | 2 +-
 29 files changed, 51 insertions(+), 17 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 0/2] Add missing audio timer period setting
Posted by Michal Prívozník 2 years, 10 months ago
On 6/3/21 10:18 AM, Daniel P. Berrangé wrote:
> Somehow I missed this one property during initial impl of audio
> 
> Daniel P. Berrangé (2):
>   conf: add support for timer period audio setting
>   qemu: wire up support for timer period audio setting
> 
>  docs/formatdomain.rst                                     | 6 +++++-
>  docs/schemas/domaincommon.rng                             | 5 +++++
>  src/conf/domain_conf.c                                    | 7 +++++++
>  src/conf/domain_conf.h                                    | 2 ++
>  src/qemu/qemu_command.c                                   | 8 ++++++++
>  tests/qemuxml2argvdata/audio-alsa-best.args               | 1 +
>  tests/qemuxml2argvdata/audio-alsa-best.x86_64-latest.args | 2 +-
>  tests/qemuxml2argvdata/audio-alsa-best.xml                | 2 +-
>  tests/qemuxml2argvdata/audio-coreaudio-best.args          | 1 +
>  .../audio-coreaudio-best.x86_64-latest.args               | 2 +-
>  tests/qemuxml2argvdata/audio-coreaudio-best.xml           | 2 +-
>  tests/qemuxml2argvdata/audio-file-best.args               | 1 +
>  tests/qemuxml2argvdata/audio-file-best.x86_64-latest.args | 2 +-
>  tests/qemuxml2argvdata/audio-file-best.xml                | 2 +-
>  tests/qemuxml2argvdata/audio-none-best.args               | 1 +
>  tests/qemuxml2argvdata/audio-none-best.x86_64-latest.args | 2 +-
>  tests/qemuxml2argvdata/audio-none-best.xml                | 2 +-
>  tests/qemuxml2argvdata/audio-oss-best.args                | 1 +
>  tests/qemuxml2argvdata/audio-oss-best.x86_64-latest.args  | 2 +-
>  tests/qemuxml2argvdata/audio-oss-best.xml                 | 2 +-
>  tests/qemuxml2argvdata/audio-pulseaudio-best.args         | 1 +
>  .../audio-pulseaudio-best.x86_64-latest.args              | 2 +-
>  tests/qemuxml2argvdata/audio-pulseaudio-best.xml          | 2 +-
>  tests/qemuxml2argvdata/audio-sdl-best.args                | 1 +
>  tests/qemuxml2argvdata/audio-sdl-best.x86_64-latest.args  | 2 +-
>  tests/qemuxml2argvdata/audio-sdl-best.xml                 | 2 +-
>  tests/qemuxml2argvdata/audio-spice-best.args              | 1 +
>  .../qemuxml2argvdata/audio-spice-best.x86_64-latest.args  | 2 +-
>  tests/qemuxml2argvdata/audio-spice-best.xml               | 2 +-
>  29 files changed, 51 insertions(+), 17 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal