meson: Various fixes and improvements

[libvirt PATCH 08/26] meson: Make libm a required dependency

Posted by Andrea Bolognani 4 years, 8 months ago

We use it unconditionally.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 81f8caae06..922bf93659 100644
--- a/meson.build
+++ b/meson.build
@@ -1022,7 +1022,7 @@ endif
 libxml_version = '2.9.1'
 libxml_dep = dependency('libxml-2.0', version: '>=' + libxml_version)
 
-libm_dep = cc.find_library('m', required: false)
+libm_dep = cc.find_library('m')
 
 netcf_version = '0.1.8'
 netcf_dep = dependency('netcf', version: '>=' + netcf_version, required: get_option('netcf'))
-- 
2.31.1

Re: [libvirt PATCH 08/26] meson: Make libm a required dependency

Posted by Pavel Hrdina 4 years, 8 months ago

On Tue, Jun 01, 2021 at 10:37:39AM +0200, Andrea Bolognani wrote:
> We use it unconditionally.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 81f8caae06..922bf93659 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1022,7 +1022,7 @@ endif
>  libxml_version = '2.9.1'
>  libxml_dep = dependency('libxml-2.0', version: '>=' + libxml_version)
>  
> -libm_dep = cc.find_library('m', required: false)
> +libm_dep = cc.find_library('m')
>  
>  netcf_version = '0.1.8'
>  netcf_dep = dependency('netcf', version: '>=' + netcf_version, required: get_option('netcf'))

You should drop it from summary as we don't list non-optional
dependencies there.

Pavel