Refactor more XML parsing boilerplate code, part XI

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part XI

Tim Wiederhake posted 10 patches 2 years, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210518150451.79954-1-twiederh@redhat.com

Test syntax-check failed

src/conf/domain_conf.c      | 168 +++++++++---------------------------
src/conf/domain_conf.h      |  23 +++--
src/conf/node_device_conf.c |  15 +---
3 files changed, 52 insertions(+), 154 deletions(-)

Expand all Fold all

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part XI

Posted by Tim Wiederhake 2 years, 11 months ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Tim Wiederhake (10):
  virDomainHostdevDef: Change type of startupPolicy to
    virDomainStartupPolicy
  virDomainHostdevSubsysUSBDefParseXML: Use virXMLProp*
  virDomainDeviceUSBMasterParseXML: Use virXMLProp*
  virDomainDiskDef: Change type of geometry.trans to
    virDomainDiskGeometryTrans
  virDomainDiskDefGeometryParse: Use virXMLProp*
  virDomainChrSourceReconnectDefParseXML: Use virXMLProp*
  virDomainChrDefParseTargetXML: Use virXMLProp*
  virDomainAudioCoreAudioParse: Use virXMLProp*
  virDomainAudioOSSParse: Use virXMLProp*
  virNodeDevCapPCIDevIommuGroupParseXML: Use virXMLProp*

 src/conf/domain_conf.c      | 168 +++++++++---------------------------
 src/conf/domain_conf.h      |  23 +++--
 src/conf/node_device_conf.c |  15 +---
 3 files changed, 52 insertions(+), 154 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part XI

Posted by Laine Stump 2 years, 11 months ago

Reviewed-by: Laine Stump <laine@redhat.com>

I'll push when the CI on my review branch is finished.

On 5/18/21 11:04 AM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Tim Wiederhake (10):
>    virDomainHostdevDef: Change type of startupPolicy to
>      virDomainStartupPolicy
>    virDomainHostdevSubsysUSBDefParseXML: Use virXMLProp*
>    virDomainDeviceUSBMasterParseXML: Use virXMLProp*
>    virDomainDiskDef: Change type of geometry.trans to
>      virDomainDiskGeometryTrans
>    virDomainDiskDefGeometryParse: Use virXMLProp*
>    virDomainChrSourceReconnectDefParseXML: Use virXMLProp*
>    virDomainChrDefParseTargetXML: Use virXMLProp*
>    virDomainAudioCoreAudioParse: Use virXMLProp*
>    virDomainAudioOSSParse: Use virXMLProp*
>    virNodeDevCapPCIDevIommuGroupParseXML: Use virXMLProp*
> 
>   src/conf/domain_conf.c      | 168 +++++++++---------------------------
>   src/conf/domain_conf.h      |  23 +++--
>   src/conf/node_device_conf.c |  15 +---
>   3 files changed, 52 insertions(+), 154 deletions(-)
>