This is a short patch series based on an initial patch from Boris Fiuczynski
that I massaged a little bit and added a few additional patches.

This allows you to define mediated devices in libvirt which are started
automatically at boot or parent device plugin.

Boris Fiuczynski (1):
  nodedev: support auto-start property for mdevs

Jonathon Jongsma (3):
  test: move nodedev xml2xml output to a separate dir
  tests: nodedevxml2xmltest: test more mdev files
  docs: nodedev: document mdev uuid property

 docs/formatnode.html.in                       | 14 ++++++++
 docs/schemas/nodedev.rng                      | 11 +++++++
 src/conf/node_device_conf.c                   | 20 ++++++++++-
 src/conf/node_device_conf.h                   | 12 +++++++
 src/libvirt_private.syms                      |  2 ++
 src/node_device/node_device_driver.c          |  7 +++-
 .../mdevctl-list-multiple.out.xml             |  4 +++
 tests/nodedevschemadata/mdev_autostart.xml    | 10 ++++++
 tests/nodedevschemadata/mdev_manual.xml       | 10 ++++++
 tests/nodedevxml2xmlout/DVD_GCC_4247N.xml     | 15 +++++++++
 tests/nodedevxml2xmlout/DVD_with_media.xml    | 18 ++++++++++
 tests/nodedevxml2xmlout/ap_07_0038.xml        |  9 +++++
 tests/nodedevxml2xmlout/ap_card07.xml         |  8 +++++
 tests/nodedevxml2xmlout/ap_matrix.xml         |  7 ++++
 .../ap_matrix_mdev_types.xml                  | 14 ++++++++
 tests/nodedevxml2xmlout/ccw_0_0_ffff.xml      | 10 ++++++
 tests/nodedevxml2xmlout/computer.xml          | 16 +++++++++
 .../css_0_0_fffe_mdev_types.xml               | 17 ++++++++++
 tests/nodedevxml2xmlout/css_0_0_ffff.xml      | 10 ++++++
 tests/nodedevxml2xmlout/drm_renderD129.xml    | 10 ++++++
 ...v_3627463d_b7f0_4fea_b468_f1da537d301b.xml |  9 +++++
 tests/nodedevxml2xmlout/mdev_autostart.xml    | 11 +++++++
 ...v_d069d019_36ea_4111_8f0a_8c9a70e21366.xml | 10 ++++++
 ...v_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml | 11 +++++++
 ...v_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml | 10 ++++++
 ...v_fedc4916_1ca8_49ac_b176_871d16c13076.xml | 10 ++++++
 tests/nodedevxml2xmlout/mdev_manual.xml       | 11 +++++++
 .../net_00_13_02_b9_f9_d3.xml                 | 21 ++++++++++++
 .../net_00_15_58_2f_e9_55.xml                 | 21 ++++++++++++
 .../pci_0000_00_02_0_header_type.xml          | 16 +++++++++
 .../pci_0000_00_1c_0_header_type.xml          | 21 ++++++++++++
 .../pci_0000_02_10_7_mdev_types.xml           | 33 +++++++++++++++++++
 .../pci_0000_02_10_7_sriov.xml                | 24 ++++++++++++++
 .../pci_0000_02_10_7_sriov_pf_vfs_all.xml     | 29 ++++++++++++++++
 ...0_02_10_7_sriov_pf_vfs_all_header_type.xml | 31 +++++++++++++++++
 .../pci_0000_02_10_7_sriov_vfs.xml            | 27 +++++++++++++++
 ..._0000_02_10_7_sriov_zero_vfs_max_count.xml | 22 +++++++++++++
 tests/nodedevxml2xmlout/pci_1002_71c4.xml     | 14 ++++++++
 .../pci_8086_0c0c_snd_hda_intel.xml           | 17 ++++++++++
 .../pci_8086_10c9_sriov_pf.xml                | 18 ++++++++++
 .../pci_8086_27c5_scsi_host.xml               |  7 ++++
 .../pci_8086_27c5_scsi_host_0.xml             |  7 ++++
 .../pci_8086_27c5_scsi_host_0_unique_id.xml   |  8 +++++
 ...i_8086_27c5_scsi_host_scsi_device_lun0.xml | 11 +++++++
 .../pci_8086_27c5_scsi_host_scsi_host.xml     |  7 ++++
 .../pci_8086_4238_pcie_wireless.xml           | 27 +++++++++++++++
 tests/nodedevxml2xmlout/scsi_target0_0_0.xml  |  7 ++++
 tests/nodedevxml2xmlout/scsi_target1_0_0.xml  | 12 +++++++
 ...rial_3600c0ff000d7a2a5d463ff4902000000.xml | 19 +++++++++++
 ...al_SATA_HTS721010G9SA00_MPCZ12Y0GNGWSE.xml | 14 ++++++++
 .../usb_device_1d6b_1_0000_00_1d_0.xml        | 10 ++++++
 .../usb_device_1d6b_1_0000_00_1d_0_if0.xml    | 10 ++++++
 tests/nodedevxml2xmltest.c                    | 17 +++++++---
 53 files changed, 739 insertions(+), 7 deletions(-)
 create mode 100644 tests/nodedevschemadata/mdev_autostart.xml
 create mode 100644 tests/nodedevschemadata/mdev_manual.xml
 create mode 100644 tests/nodedevxml2xmlout/DVD_GCC_4247N.xml
 create mode 100644 tests/nodedevxml2xmlout/DVD_with_media.xml
 create mode 100644 tests/nodedevxml2xmlout/ap_07_0038.xml
 create mode 100644 tests/nodedevxml2xmlout/ap_card07.xml
 create mode 100644 tests/nodedevxml2xmlout/ap_matrix.xml
 create mode 100644 tests/nodedevxml2xmlout/ap_matrix_mdev_types.xml
 create mode 100644 tests/nodedevxml2xmlout/ccw_0_0_ffff.xml
 create mode 100644 tests/nodedevxml2xmlout/computer.xml
 create mode 100644 tests/nodedevxml2xmlout/css_0_0_fffe_mdev_types.xml
 create mode 100644 tests/nodedevxml2xmlout/css_0_0_ffff.xml
 create mode 100644 tests/nodedevxml2xmlout/drm_renderD129.xml
 create mode 100644 tests/nodedevxml2xmlout/mdev_3627463d_b7f0_4fea_b468_f1da537d301b.xml
 create mode 100644 tests/nodedevxml2xmlout/mdev_autostart.xml
 create mode 100644 tests/nodedevxml2xmlout/mdev_d069d019_36ea_4111_8f0a_8c9a70e21366.xml
 create mode 100644 tests/nodedevxml2xmlout/mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml
 create mode 100644 tests/nodedevxml2xmlout/mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml
 create mode 100644 tests/nodedevxml2xmlout/mdev_fedc4916_1ca8_49ac_b176_871d16c13076.xml
 create mode 100644 tests/nodedevxml2xmlout/mdev_manual.xml
 create mode 100644 tests/nodedevxml2xmlout/net_00_13_02_b9_f9_d3.xml
 create mode 100644 tests/nodedevxml2xmlout/net_00_15_58_2f_e9_55.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_0000_00_02_0_header_type.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_0000_00_1c_0_header_type.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_mdev_types.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov_pf_vfs_all.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov_pf_vfs_all_header_type.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov_vfs.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov_zero_vfs_max_count.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_1002_71c4.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_8086_0c0c_snd_hda_intel.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_8086_10c9_sriov_pf.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host_0.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host_0_unique_id.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host_scsi_device_lun0.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host_scsi_host.xml
 create mode 100644 tests/nodedevxml2xmlout/pci_8086_4238_pcie_wireless.xml
 create mode 100644 tests/nodedevxml2xmlout/scsi_target0_0_0.xml
 create mode 100644 tests/nodedevxml2xmlout/scsi_target1_0_0.xml
 create mode 100644 tests/nodedevxml2xmlout/storage_serial_3600c0ff000d7a2a5d463ff4902000000.xml
 create mode 100644 tests/nodedevxml2xmlout/storage_serial_SATA_HTS721010G9SA00_MPCZ12Y0GNGWSE.xml
 create mode 100644 tests/nodedevxml2xmlout/usb_device_1d6b_1_0000_00_1d_0.xml
 create mode 100644 tests/nodedevxml2xmlout/usb_device_1d6b_1_0000_00_1d_0_if0.xml

-- 
2.31.1

On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote:
> This is a short patch series based on an initial patch from Boris Fiuczynski
> that I massaged a little bit and added a few additional patches.
> 
> This allows you to define mediated devices in libvirt which are started
> automatically at boot or parent device plugin.

Sorry I missed review of this series before it was merged, but I think
this design aproach is seriously wrong. This is exposing autostart as
an XML property, but in all other parts of libvirt we expose autostart
as an explicit API. I think we need to make the implemnentation
consistent with the rest of libvirt.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On Tue, 2021-05-25 at 11:20 +0100, Daniel P. Berrangé wrote:
> On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote:
> > This is a short patch series based on an initial patch from Boris
> > Fiuczynski
> > that I massaged a little bit and added a few additional patches.
> > 
> > This allows you to define mediated devices in libvirt which are
> > started
> > automatically at boot or parent device plugin.
> 
> Sorry I missed review of this series before it was merged, but I
> think
> this design aproach is seriously wrong. This is exposing autostart as
> an XML property, but in all other parts of libvirt we expose
> autostart
> as an explicit API. I think we need to make the implemnentation
> consistent with the rest of libvirt.
> 
> 
> Regards,
> Daniel


Hmm, you're right. Sorry I didn't catch that. Should we revert these
patches for now then? I'll try to come up with a new implementation.

Jonathon

On Tue, May 25, 2021 at 11:36:59AM -0500, Jonathon Jongsma wrote:
> On Tue, 2021-05-25 at 11:20 +0100, Daniel P. Berrangé wrote:
> > On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote:
> > > This is a short patch series based on an initial patch from Boris
> > > Fiuczynski
> > > that I massaged a little bit and added a few additional patches.
> > > 
> > > This allows you to define mediated devices in libvirt which are
> > > started
> > > automatically at boot or parent device plugin.
> > 
> > Sorry I missed review of this series before it was merged, but I
> > think
> > this design aproach is seriously wrong. This is exposing autostart as
> > an XML property, but in all other parts of libvirt we expose
> > autostart
> > as an explicit API. I think we need to make the implemnentation
> > consistent with the rest of libvirt.
> 
> Hmm, you're right. Sorry I didn't catch that. Should we revert these
> patches for now then? I'll try to come up with a new implementation.

Several of the patches are still useful. Only the 2nd patch and some
files in the 3rd are impacted I think.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On 5/25/21 12:20 PM, Daniel P. Berrangé wrote:
> On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote:
>> This is a short patch series based on an initial patch from Boris Fiuczynski
>> that I massaged a little bit and added a few additional patches.
>>
>> This allows you to define mediated devices in libvirt which are started
>> automatically at boot or parent device plugin.
> 
> Sorry I missed review of this series before it was merged, but I think
> this design aproach is seriously wrong. This is exposing autostart as
> an XML property, but in all other parts of libvirt we expose autostart
> as an explicit API. I think we need to make the implemnentation
> consistent with the rest of libvirt.

Daniel,
just wondering, if libvirt exposes this as an explicit API would the 
assumption be that when a user sets up the device to autostart via 
libvirt after a system reboot libvirt takes care of everything to bring 
the device back up again?

mdevctl does not take care of device driver binding of alternative 
device drivers, e.g. vfio.

Does that meet libvirt user expectations and be consistent with the rest 
of libvirt?

> 
> 
> Regards,
> Daniel
> 


-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

On Wed, Jun 09, 2021 at 11:25:26AM +0200, Boris Fiuczynski wrote:
> On 5/25/21 12:20 PM, Daniel P. Berrangé wrote:
> > On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote:
> > > This is a short patch series based on an initial patch from Boris Fiuczynski
> > > that I massaged a little bit and added a few additional patches.
> > > 
> > > This allows you to define mediated devices in libvirt which are started
> > > automatically at boot or parent device plugin.
> > 
> > Sorry I missed review of this series before it was merged, but I think
> > this design aproach is seriously wrong. This is exposing autostart as
> > an XML property, but in all other parts of libvirt we expose autostart
> > as an explicit API. I think we need to make the implemnentation
> > consistent with the rest of libvirt.
> 
> Daniel,
> just wondering, if libvirt exposes this as an explicit API would the
> assumption be that when a user sets up the device to autostart via libvirt
> after a system reboot libvirt takes care of everything to bring the device
> back up again?
> 
> mdevctl does not take care of device driver binding of alternative device
> drivers, e.g. vfio.
> 
> Does that meet libvirt user expectations and be consistent with the rest of
> libvirt?

Autostart merely means that the equivalent of virNodeDeviceCreate is
done at startup. 


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|