[v2] Refactor more XML parsing boilerplate code, part X

[libvirt PATCH v2 0/6] Refactor more XML parsing boilerplate code, part X

Tim Wiederhake posted 6 patches 2 years, 11 months ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210513153201.20407-1-twiederh@redhat.com

src/conf/node_device_conf.c                   |  44 ++-
src/conf/numa_conf.c                          | 305 ++++++------------
.../hugepages-memaccess-invalid.err           |   2 +-
3 files changed, 110 insertions(+), 241 deletions(-)

Expand all Fold all

[libvirt PATCH v2 0/6] Refactor more XML parsing boilerplate code, part X

Posted by Tim Wiederhake 2 years, 11 months ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Changes since V1:
* Split up VIR_FREE'd and reused ´g_autofree xmlNodePtr *´ variables.

Tim Wiederhake (6):
  virNodeDeviceDefParseXML: Use g_auto*
  virDomainNumatuneNodeParseXML: Use virXMLProp*
  virDomainNumatuneNodeParseXML: Use g_autofree
  virDomainNumaDefNodeDistanceParseXML: Use virXMLProp*
  virDomainNumaDefParseXML: Use virXMLProp*
  virDomainNumaDefParseXML: Use g_autofree

 src/conf/node_device_conf.c                   |  44 ++-
 src/conf/numa_conf.c                          | 305 ++++++------------
 .../hugepages-memaccess-invalid.err           |   2 +-
 3 files changed, 110 insertions(+), 241 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH v2 0/6] Refactor more XML parsing boilerplate code, part X

Posted by Laine Stump 2 years, 11 months ago

On 5/13/21 11:31 AM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Changes since V1:
> * Split up VIR_FREE'd and reused ´g_autofree xmlNodePtr *´ variables.
> 
> Tim Wiederhake (6):
>    virNodeDeviceDefParseXML: Use g_auto*
>    virDomainNumatuneNodeParseXML: Use virXMLProp*
>    virDomainNumatuneNodeParseXML: Use g_autofree
>    virDomainNumaDefNodeDistanceParseXML: Use virXMLProp*
>    virDomainNumaDefParseXML: Use virXMLProp*
>    virDomainNumaDefParseXML: Use g_autofree
> 
>   src/conf/node_device_conf.c                   |  44 ++-
>   src/conf/numa_conf.c                          | 305 ++++++------------
>   .../hugepages-memaccess-invalid.err           |   2 +-
>   3 files changed, 110 insertions(+), 241 deletions(-)
> 

Reviewed-by: Laine Stump <laine@redhat.com>

I'll push them as soon as simple smoke test build has completed