rpm: Set version information for libvirt-admin virtual name

[PATCH] rpm: Set version information for libvirt-admin virtual name

Neal Gompa posted 1 patch 2 years, 11 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210511232223.1422258-1-ngompa13@gmail.com

libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] rpm: Set version information for libvirt-admin virtual name

Posted by Neal Gompa 2 years, 11 months ago

The libvirt-daemon package now provides the 'libvirt-admin' virtual
name, but the Provides stanza doesn't declare version information,
which breaks things depending on that package using a versioned
dependency. Fix this by setting the version-release of libvirt to
that name to mimic the previous state.

Fixes: 2244ac168d42c3fa424bae6d33ecdbb8726da7c2

Signed-off-by: Neal Gompa <ngompa13@gmail.com>
---
 libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 9dea6c6787..d7a90c42f5 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -415,7 +415,7 @@ Requires: gettext
 
 # Ensure smooth upgrades
 Obsoletes: libvirt-admin < 7.3.0
-Provides: libvirt-admin
+Provides: libvirt-admin = %{version}-%{release}
 Obsoletes: libvirt-bash-completion < 7.3.0
 
 %description daemon
-- 
2.31.1

Re: [PATCH] rpm: Set version information for libvirt-admin virtual name

Posted by Michal Prívozník 2 years, 11 months ago

On 5/12/21 1:22 AM, Neal Gompa wrote:
> The libvirt-daemon package now provides the 'libvirt-admin' virtual
> name, but the Provides stanza doesn't declare version information,
> which breaks things depending on that package using a versioned
> dependency. Fix this by setting the version-release of libvirt to
> that name to mimic the previous state.
> 
> Fixes: 2244ac168d42c3fa424bae6d33ecdbb8726da7c2
> 
> Signed-off-by: Neal Gompa <ngompa13@gmail.com>
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal