Refactor more XML parsing boilerplate code, part IX

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IX

Tim Wiederhake posted 10 patches 2 years, 11 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210510124841.123066-1-twiederh@redhat.com

src/conf/domain_conf.c      | 64 ++++++++++---------------
src/conf/network_conf.c     | 32 +++++--------
src/conf/network_conf.h     |  2 +-
src/conf/node_device_conf.c | 94 ++++++++-----------------------------
src/conf/node_device_conf.h |  2 +
src/network/bridge_driver.c |  2 +-
6 files changed, 62 insertions(+), 134 deletions(-)

Expand all Fold all

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IX

Posted by Tim Wiederhake 2 years, 11 months ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Tim Wiederhake (10):
  virDomainObjParseXML: Use virXMLProp*
  virDomainObjParseXML: Use g_autoptr
  virNetworkDHCPLeaseTimeDef: Make expiry unsigned long long
  virNetworkDHCPLeaseTimeDefParseXML: Use virXMLProp*
  virPCIEDeviceInfoLinkParseXML: Use virXMLProp*
  virPCIEDeviceInfoLinkParseXML: Remove unused parameter ctxt
  virNodeDevCapsDefParseXML: Use virXMLProp*
  conf: node_device: Register autoptr cleanup function for
    virNodeDevCapsDef
  virNodeDevCapsDefParseXML: Use g_autoptr
  virNodeDeviceDefParseXML: Use virXMLProp*

 src/conf/domain_conf.c      | 64 ++++++++++---------------
 src/conf/network_conf.c     | 32 +++++--------
 src/conf/network_conf.h     |  2 +-
 src/conf/node_device_conf.c | 94 ++++++++-----------------------------
 src/conf/node_device_conf.h |  2 +
 src/network/bridge_driver.c |  2 +-
 6 files changed, 62 insertions(+), 134 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IX

Posted by Michal Prívozník 2 years, 11 months ago

On 5/10/21 2:48 PM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Tim Wiederhake (10):
>   virDomainObjParseXML: Use virXMLProp*
>   virDomainObjParseXML: Use g_autoptr
>   virNetworkDHCPLeaseTimeDef: Make expiry unsigned long long
>   virNetworkDHCPLeaseTimeDefParseXML: Use virXMLProp*
>   virPCIEDeviceInfoLinkParseXML: Use virXMLProp*
>   virPCIEDeviceInfoLinkParseXML: Remove unused parameter ctxt
>   virNodeDevCapsDefParseXML: Use virXMLProp*
>   conf: node_device: Register autoptr cleanup function for
>     virNodeDevCapsDef
>   virNodeDevCapsDefParseXML: Use g_autoptr
>   virNodeDeviceDefParseXML: Use virXMLProp*
> 
>  src/conf/domain_conf.c      | 64 ++++++++++---------------
>  src/conf/network_conf.c     | 32 +++++--------
>  src/conf/network_conf.h     |  2 +-
>  src/conf/node_device_conf.c | 94 ++++++++-----------------------------
>  src/conf/node_device_conf.h |  2 +
>  src/network/bridge_driver.c |  2 +-
>  6 files changed, 62 insertions(+), 134 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal