[v3] Refactor more XML parsing boilerplate code, part VI

[libvirt PATCH v3 0/4] Refactor more XML parsing boilerplate code, part VI

Tim Wiederhake posted 4 patches 2 years, 11 months ago

Diff against v1 v2
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210505105548.95348-1-twiederh@redhat.com

src/conf/domain_conf.c | 195 +++++++++++++++++------------------------
1 file changed, 80 insertions(+), 115 deletions(-)

Expand all Fold all

[libvirt PATCH v3 0/4] Refactor more XML parsing boilerplate code, part VI

Posted by Tim Wiederhake 2 years, 11 months ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

V1: https://listman.redhat.com/archives/libvir-list/2021-April/msg01184.html
V2: https://listman.redhat.com/archives/libvir-list/2021-April/msg01238.html

Changes since V2:
* Rebased
* Prepended patches to fix issues in the function
* Removed superfluous "VIR_XML_PROP_NONE"

Tim Wiederhake (4):
  virDomainFSDefParseXML: Remove unused variables
  virDomainGraphicsDefParseXMLSpice: Fix variable type
  virDomainGraphicsDefParseXMLSpice: Make name and mode mandatory
  virDomainGraphicsDefParseXMLSpice: Use virXMLProp*

 src/conf/domain_conf.c | 195 +++++++++++++++++------------------------
 1 file changed, 80 insertions(+), 115 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH v3 0/4] Refactor more XML parsing boilerplate code, part VI

Posted by Michal Prívozník 2 years, 11 months ago

On 5/5/21 12:55 PM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> V1: https://listman.redhat.com/archives/libvir-list/2021-April/msg01184.html
> V2: https://listman.redhat.com/archives/libvir-list/2021-April/msg01238.html
> 
> Changes since V2:
> * Rebased
> * Prepended patches to fix issues in the function
> * Removed superfluous "VIR_XML_PROP_NONE"
> 
> Tim Wiederhake (4):
>   virDomainFSDefParseXML: Remove unused variables
>   virDomainGraphicsDefParseXMLSpice: Fix variable type
>   virDomainGraphicsDefParseXMLSpice: Make name and mode mandatory
>   virDomainGraphicsDefParseXMLSpice: Use virXMLProp*
> 
>  src/conf/domain_conf.c | 195 +++++++++++++++++------------------------
>  1 file changed, 80 insertions(+), 115 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal