Refactor more XML parsing boilerplate code, part VIII

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VIII

Posted by Tim Wiederhake 2 years, 11 months ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Note that patch #1 depends on
https://listman.redhat.com/archives/libvir-list/2021-April/msg01260.html
from part VII.

Tim Wiederhake (10):
  virDomainRedirFilterUSBDevDefParseXML: Use g_auto*
  virDomainPerfEventDefParseXML: Use virXMLProp*
  virDomainMemoryDefParseXML: Use virXMLProp*
  virDomainVcpuPinDefParseXML: Use virXMLProp*
  virDomainIOThreadPinDefParseXML: Use virXMLProp*
  virDomainSchedulerParseCommonAttrs: Use virXMLProp*
  virDomainDef: Change type of placement_mode to
    virDomainCpuPlacementMode
  virDomainVcpuParse: Use virXMLProp*
  virDomainCachetuneDefParseCache: Use virXMLProp*
  virDomainResctrlMonDefParse: Use virXMLProp*

 src/conf/domain_conf.c | 300 +++++++++--------------------------------
 src/conf/domain_conf.h |   2 +-
 2 files changed, 63 insertions(+), 239 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VIII

Posted by Michal Prívozník 2 years, 11 months ago

On 5/4/21 4:02 PM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Note that patch #1 depends on
> https://listman.redhat.com/archives/libvir-list/2021-April/msg01260.html
> from part VII.
> 
> Tim Wiederhake (10):
>   virDomainRedirFilterUSBDevDefParseXML: Use g_auto*
>   virDomainPerfEventDefParseXML: Use virXMLProp*
>   virDomainMemoryDefParseXML: Use virXMLProp*
>   virDomainVcpuPinDefParseXML: Use virXMLProp*
>   virDomainIOThreadPinDefParseXML: Use virXMLProp*
>   virDomainSchedulerParseCommonAttrs: Use virXMLProp*
>   virDomainDef: Change type of placement_mode to
>     virDomainCpuPlacementMode
>   virDomainVcpuParse: Use virXMLProp*
>   virDomainCachetuneDefParseCache: Use virXMLProp*
>   virDomainResctrlMonDefParse: Use virXMLProp*
> 
>  src/conf/domain_conf.c | 300 +++++++++--------------------------------
>  src/conf/domain_conf.h |   2 +-
>  2 files changed, 63 insertions(+), 239 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal