[v1] docs: cputune is also supported by the xen driver

[PATCH v1] docs: cputune is also supported by the xen driver

Posted by Olaf Hering 2 years, 11 months ago

Since commit 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3 libxl also handles
a domain/cputune/vcpupin element in domU.xml.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 docs/formatdomain.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 282176c4f4..0328fe488b 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -744,8 +744,8 @@ CPU Tuning
    of element ``vcpu`` is not specified, the vCPU is pinned to all the physical
    CPUs by default. It contains two required attributes, the attribute ``vcpu``
    specifies vCPU id, and the attribute ``cpuset`` is same as attribute
-   ``cpuset`` of element ``vcpu``. (NB: Only qemu driver support) :since:`Since
-   0.9.0`
+   ``cpuset`` of element ``vcpu``. (NB: Only qemu and xen driver support)
+   :since:`Since 0.9.0`
 ``emulatorpin``
    The optional ``emulatorpin`` element specifies which of host physical CPUs
    the "emulator", a subset of a domain not including vCPU or iothreads will be

Re: [PATCH v1] docs: cputune is also supported by the xen driver

Posted by Jim Fehlig 2 years, 11 months ago

On 5/3/21 5:33 AM, Olaf Hering wrote:
> Since commit 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3 libxl also handles
> a domain/cputune/vcpupin element in domU.xml.

git describe --contains 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3
v0.9.1~83

> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>   docs/formatdomain.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index 282176c4f4..0328fe488b 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -744,8 +744,8 @@ CPU Tuning
>      of element ``vcpu`` is not specified, the vCPU is pinned to all the physical
>      CPUs by default. It contains two required attributes, the attribute ``vcpu``
>      specifies vCPU id, and the attribute ``cpuset`` is same as attribute
> -   ``cpuset`` of element ``vcpu``. (NB: Only qemu driver support) :since:`Since
> -   0.9.0`
> +   ``cpuset`` of element ``vcpu``. (NB: Only qemu and xen driver support)
> +   :since:`Since 0.9.0`

So this isn't quite right.

IMO we can also improve the wording while at it. E.g. "QEMU driver support since 
0.9.0, Xen driver support since 0.9.1". That would be similar to the period, 
quota, etc descriptions, minus the unnecessary use of "Only".

Jim