Refactor more XML parsing boilerplate code, part VII

[libvirt PATCH 08/10] conf: domain: Register autoptr cleanup function for virDomainDeviceDef

Posted by Tim Wiederhake 4 years, 9 months ago

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 src/conf/domain_conf.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 581ccb05a9..8133d19fca 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -3270,6 +3270,7 @@ void virDomainHubDefFree(virDomainHubDef *def);
 void virDomainRedirdevDefFree(virDomainRedirdevDef *def);
 void virDomainRedirFilterDefFree(virDomainRedirFilterDef *def);
 void virDomainShmemDefFree(virDomainShmemDef *def);
+G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainShmemDef, virDomainShmemDefFree);
 void virDomainDeviceDefFree(virDomainDeviceDef *def);
 
 G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainDeviceDef, virDomainDeviceDefFree);
-- 
2.26.3

Re: [libvirt PATCH 08/10] conf: domain: Register autoptr cleanup function for virDomainDeviceDef

Posted by Jonathon Jongsma 4 years, 9 months ago

in the subject, I think you meant to say virDomainShmemDef?

On Tue, 2021-04-27 at 17:04 +0200, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> ---
>  src/conf/domain_conf.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 581ccb05a9..8133d19fca 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -3270,6 +3270,7 @@ void virDomainHubDefFree(virDomainHubDef *def);
>  void virDomainRedirdevDefFree(virDomainRedirdevDef *def);
>  void virDomainRedirFilterDefFree(virDomainRedirFilterDef *def);
>  void virDomainShmemDefFree(virDomainShmemDef *def);
> +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainShmemDef,
> virDomainShmemDefFree);
>  void virDomainDeviceDefFree(virDomainDeviceDef *def);
>  
>  G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainDeviceDef,
> virDomainDeviceDefFree);

Re: [libvirt PATCH 08/10] conf: domain: Register autoptr cleanup function for virDomainDeviceDef

Posted by Ján Tomko 4 years, 9 months ago

On a Tuesday in 2021, Tim Wiederhake wrote:
>Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
>---
> src/conf/domain_conf.h | 1 +
> 1 file changed, 1 insertion(+)
>

With the commit summary fixed:

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano