[PATCH v2] formatdomain.rst: update slice xml in "Hard drives" part

MeinaLi posted 1 patch 3 weeks, 2 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210425064450.898434-1-meili@redhat.com
docs/formatdomain.rst | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

[PATCH v2] formatdomain.rst: update slice xml in "Hard drives" part

Posted by MeinaLi 3 weeks, 2 days ago
The disk type=’lun’ doesn't support storage slice, which was introduced in:
5d72c3ce28 qemu: domain: Forbid slice/encryption/copy_on_read with disk type='lun'

Signed-off-by: Meina Li <meili@redhat.com>
---
 docs/formatdomain.rst | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 1b9b221611..7bd5e685e8 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -2381,9 +2381,6 @@ paravirtualized driver is specified via the ``disk`` element.
      <disk type='block' device='lun'>
        <driver name='qemu' type='raw'/>
        <source dev='/dev/sda'>
-         <slices>
-           <slice type='storage' offset='12345' size='123'/>
-         </slices>
          <reservations managed='no'>
            <source type='unix' path='/path/to/qemu-pr-helper' mode='client'/>
          </reservations>
@@ -2393,7 +2390,11 @@ paravirtualized driver is specified via the ``disk`` element.
      </disk>
      <disk type='block' device='disk'>
        <driver name='qemu' type='raw'/>
-       <source dev='/dev/sda'/>
+       <source dev='/dev/sda'>
+         <slices>
+           <slice type='storage' offset='12345' size='123'/>
+         </slices>
+       </source>
        <geometry cyls='16383' heads='16' secs='63' trans='lba'/>
        <blockio logical_block_size='512' physical_block_size='4096'/>
        <target dev='hdj' bus='ide'/>
-- 
2.27.0