[v2] Refactor more XML parsing boilerplate code, part V

[libvirt PATCH v2 00/11] Refactor more XML parsing boilerplate code, part V

Posted by Tim Wiederhake 3 years ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Changes since V1:
* Split up patch for virDomainControllerDefParseXML
* Code style fixes

Tim Wiederhake (11):
  virXMLPropEnum: Fix return value
  virDomainControllerDef: Change type of ioeventfd to virTristateSwitch
  virDomainPCIControllerOpts: Change type of modelName to
    virDomainControllerPCIModelName
  virDomainControllerDefParseXML: Use virXMLProp*
  virDomainControllerDefParseXML: Cosmetic changes
  virDomainActualNetDef: Change type of type to virDomainNetType
  virDomainActualNetDefParseXML: Use virXMLProp*
  virDomainNetDefParseXML: Use virXMLProp*
  virDomainGraphicsListenDefParseXML: Use virXMLProp*
  virDomainGraphicsDef: Change type of sharePolicy to
    virDomainGraphicsVNCSharePolicy
  virDomainGraphicsDefParseXMLVNC: Use virXMLProp*

 src/conf/domain_conf.c         | 643 +++++++++++----------------------
 src/conf/domain_conf.h         |   8 +-
 src/qemu/qemu_domain_address.c |   2 +-
 src/util/virxml.c              |   2 +-
 4 files changed, 227 insertions(+), 428 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH v2 00/11] Refactor more XML parsing boilerplate code, part V

Posted by Ján Tomko 2 years, 12 months ago

On a Friday in 2021, Tim Wiederhake wrote:
>For background, see
>https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
>
>Changes since V1:
>* Split up patch for virDomainControllerDefParseXML
>* Code style fixes
>
>Tim Wiederhake (11):
>  virXMLPropEnum: Fix return value
>  virDomainControllerDef: Change type of ioeventfd to virTristateSwitch
>  virDomainPCIControllerOpts: Change type of modelName to
>    virDomainControllerPCIModelName
>  virDomainControllerDefParseXML: Use virXMLProp*
>  virDomainControllerDefParseXML: Cosmetic changes
>  virDomainActualNetDef: Change type of type to virDomainNetType
>  virDomainActualNetDefParseXML: Use virXMLProp*
>  virDomainNetDefParseXML: Use virXMLProp*
>  virDomainGraphicsListenDefParseXML: Use virXMLProp*
>  virDomainGraphicsDef: Change type of sharePolicy to
>    virDomainGraphicsVNCSharePolicy
>  virDomainGraphicsDefParseXMLVNC: Use virXMLProp*
>
> src/conf/domain_conf.c         | 643 +++++++++++----------------------
> src/conf/domain_conf.h         |   8 +-
> src/qemu/qemu_domain_address.c |   2 +-
> src/util/virxml.c              |   2 +-
> 4 files changed, 227 insertions(+), 428 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano