Refactor more XML parsing boilerplate code, part III

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part III

Tim Wiederhake posted 10 patches 3 years ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210421155133.162030-1-twiederh@redhat.com

src/conf/domain_conf.c             | 214 ++++++++---------------------
src/conf/domain_conf.h             |   4 +-
src/conf/storage_encryption_conf.c |  16 +--
src/libvirt_private.syms           |   1 +
src/qemu/qemu_command.c            |   3 +-
src/util/virxml.c                  |  56 ++++++++
src/util/virxml.h                  |   8 ++
7 files changed, 125 insertions(+), 177 deletions(-)

Expand all Fold all

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part III

Posted by Tim Wiederhake 3 years ago

For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Tim Wiederhake (10):
  virDomainKeyWrapCipherDefParseXML: Use virXMLProp*
  virDomainKeyWrapDef: Make members virTristateSwitch
  qemuAppendKeyWrapMachineParm: Stricten parameter types
  virxml: Add virXMLPropULongLong
  virDomainDeviceDimmAddressParseXML: Use virXMLProp*
  virDomainHostdevSubsysSCSIHostDefParseXML: Use virXMLProp*
  virStorageEncryptionInfoParseCipher: Use virXMLProp*
  virDomainDeviceInfoParseXML: Use virXMLProp*
  virDomainDiskSourceNetworkParse: Use virXMLProp*
  virDomainMemorytuneDefParseMemory: Use virXMLProp*

 src/conf/domain_conf.c             | 214 ++++++++---------------------
 src/conf/domain_conf.h             |   4 +-
 src/conf/storage_encryption_conf.c |  16 +--
 src/libvirt_private.syms           |   1 +
 src/qemu/qemu_command.c            |   3 +-
 src/util/virxml.c                  |  56 ++++++++
 src/util/virxml.h                  |   8 ++
 7 files changed, 125 insertions(+), 177 deletions(-)

-- 
2.26.3

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part III

Posted by Michal Privoznik 3 years ago

On 4/21/21 5:51 PM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Tim Wiederhake (10):
>    virDomainKeyWrapCipherDefParseXML: Use virXMLProp*
>    virDomainKeyWrapDef: Make members virTristateSwitch
>    qemuAppendKeyWrapMachineParm: Stricten parameter types
>    virxml: Add virXMLPropULongLong
>    virDomainDeviceDimmAddressParseXML: Use virXMLProp*
>    virDomainHostdevSubsysSCSIHostDefParseXML: Use virXMLProp*
>    virStorageEncryptionInfoParseCipher: Use virXMLProp*
>    virDomainDeviceInfoParseXML: Use virXMLProp*
>    virDomainDiskSourceNetworkParse: Use virXMLProp*
>    virDomainMemorytuneDefParseMemory: Use virXMLProp*
> 
>   src/conf/domain_conf.c             | 214 ++++++++---------------------
>   src/conf/domain_conf.h             |   4 +-
>   src/conf/storage_encryption_conf.c |  16 +--
>   src/libvirt_private.syms           |   1 +
>   src/qemu/qemu_command.c            |   3 +-
>   src/util/virxml.c                  |  56 ++++++++
>   src/util/virxml.h                  |   8 ++
>   7 files changed, 125 insertions(+), 177 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal