[libvirt PATCH v2 3/5] cmdCheckpointList: Fix memory leak

Tim Wiederhake posted 5 patches 4 years, 9 months ago
[libvirt PATCH v2 3/5] cmdCheckpointList: Fix memory leak
Posted by Tim Wiederhake 4 years, 9 months ago
Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 tools/virsh-checkpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c
index 20a02b0b02..afe849dd16 100644
--- a/tools/virsh-checkpoint.c
+++ b/tools/virsh-checkpoint.c
@@ -721,7 +721,6 @@ cmdCheckpointList(vshControl *ctl,
     virDomainCheckpointPtr checkpoint = NULL;
     long long creation_longlong;
     g_autoptr(GDateTime) then = NULL;
-    g_autofree gchar *thenstr = NULL;
     bool tree = vshCommandOptBool(cmd, "tree");
     bool name = vshCommandOptBool(cmd, "name");
     bool from = vshCommandOptBool(cmd, "from");
@@ -804,6 +803,7 @@ cmdCheckpointList(vshControl *ctl,
     }
 
     for (i = 0; i < checkpointlist->nchks; i++) {
+        g_autofree gchar *thenstr = NULL;
         const char *chk_name;
 
         /* free up memory from previous iterations of the loop */
-- 
2.26.3

Re: [libvirt PATCH v2 3/5] cmdCheckpointList: Fix memory leak
Posted by Laine Stump 4 years, 9 months ago
On 4/19/21 7:54 AM, Tim Wiederhake wrote:
> Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2

As with the last patch, a short description would have gained me the 
time I spent looking into the original patch (on the other hand, not 
having the explanation forces me to go back to the source to verify the 
problem and the fix, so...)

> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>

Reviewed-by: Laine Stump <laine@redhat.com>