[PATCH 0/1] vircgroup: Fix nested cgroup on cleanup

Eric Farman posted 1 patch 2 weeks, 4 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210326162503.1565199-1-farman@linux.ibm.com
src/util/vircgroup.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 0/1] vircgroup: Fix nested cgroup on cleanup

Posted by Eric Farman 2 weeks, 4 days ago
Hi Pavel, et al,

Running Fedora 33 KVM/QEMU on s390x, I recently noticed a couple
of oddities when shutting down my guests, which I bisected between
7.0.0 and 7.1.0 to your commit:

  commit 184245f53b94fc84f727eb6e8a2aa52df02d69c0
  Author: Pavel Hrdina <phrdina@redhat.com>
  Date:   Tue Feb 9 12:33:53 2021 +0100

      vircgroup: introduce nested cgroup to properly work with systemd

The attached patch is based on some of the tweaks you did to use the
parent/nested pointers in a cgroup, rather than a cgroup itself.
It fixes both problems I'm encountering, but as this code is quite
unfamiliar to me, I might well be way off track and would appreciate
your feedback in the matter.

Apologies for hitting this on the same day as freeze; I had not
noticed the messages previously, and started digging yesterday when
I noted the number of file descriptors left open by libvirt.

Thanks,
Eric

Eric Farman (1):
  vircgroup: Cleanup nested cgroups

 src/util/vircgroup.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.25.1

Re: [PATCH 0/1] vircgroup: Fix nested cgroup on cleanup

Posted by Eric Farman 6 days, 20 hours ago
Polite ping, now that release freeze has finished.

On 3/26/21 12:25 PM, Eric Farman wrote:
> Hi Pavel, et al,
> 
> Running Fedora 33 KVM/QEMU on s390x, I recently noticed a couple
> of oddities when shutting down my guests, which I bisected between
> 7.0.0 and 7.1.0 to your commit:
> 
>    commit 184245f53b94fc84f727eb6e8a2aa52df02d69c0
>    Author: Pavel Hrdina <phrdina@redhat.com>
>    Date:   Tue Feb 9 12:33:53 2021 +0100
> 
>        vircgroup: introduce nested cgroup to properly work with systemd
> 
> The attached patch is based on some of the tweaks you did to use the
> parent/nested pointers in a cgroup, rather than a cgroup itself.
> It fixes both problems I'm encountering, but as this code is quite
> unfamiliar to me, I might well be way off track and would appreciate
> your feedback in the matter.
> 
> Apologies for hitting this on the same day as freeze; I had not
> noticed the messages previously, and started digging yesterday when
> I noted the number of file descriptors left open by libvirt.
> 
> Thanks,
> Eric
> 
> Eric Farman (1):
>    vircgroup: Cleanup nested cgroups
> 
>   src/util/vircgroup.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>