[libvirt PATCH v3 00/10] ci: Add helper script

Andrea Bolognani posted 10 patches 3 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210312172822.244833-1-abologna@redhat.com
build-aux/syntax-check.mk |   1 +
ci/Makefile               |  13 +-
ci/cirrus/refresh         |  22 ----
ci/containers/refresh     |  41 ------
ci/helper                 | 260 ++++++++++++++++++++++++++++++++++++++
5 files changed, 273 insertions(+), 64 deletions(-)
delete mode 100755 ci/cirrus/refresh
delete mode 100755 ci/containers/refresh
create mode 100755 ci/helper
[libvirt PATCH v3 00/10] ci: Add helper script
Posted by Andrea Bolognani 3 years, 1 month ago
Changes from [v2]:

  * address review feedback;

  * wrap more Makefile functionality;

  * split into smaller, easier to review patches.

Changes from [v1]:

  * implement (partial) support for running builds and spawning
    shells inside the container;

  * make the code more maintainable by using a couple of classes.


[v2] https://listman.redhat.com/archives/libvir-list/2021-February/msg00922.html
[v1] https://listman.redhat.com/archives/libvir-list/2021-February/msg00900.html

Andrea Bolognani (10):
  syntax-check: Allow exceptions for sc_prohibit_nonreentrant
  ci: Fix name for ci-test target in help output
  ci: Add helper script
  ci: Implement 'refresh' helper action
  ci: Implement 'list-images' helper action
  ci: Implement 'shell' helper action
  ci: Implement 'build' helper action
  ci: Implement 'test' helper action
  ci: Delete refresh scripts
  ci: Discourage users from using the Makefile directly

 build-aux/syntax-check.mk |   1 +
 ci/Makefile               |  13 +-
 ci/cirrus/refresh         |  22 ----
 ci/containers/refresh     |  41 ------
 ci/helper                 | 260 ++++++++++++++++++++++++++++++++++++++
 5 files changed, 273 insertions(+), 64 deletions(-)
 delete mode 100755 ci/cirrus/refresh
 delete mode 100755 ci/containers/refresh
 create mode 100755 ci/helper

-- 
2.26.2


Re: [libvirt PATCH v3 00/10] ci: Add helper script
Posted by Erik Skultety 3 years, 1 month ago
On Fri, Mar 12, 2021 at 06:28:12PM +0100, Andrea Bolognani wrote:
> Changes from [v2]:
> 
>   * address review feedback;
> 
>   * wrap more Makefile functionality;
> 
>   * split into smaller, easier to review patches.
> 
> Changes from [v1]:
> 
>   * implement (partial) support for running builds and spawning
>     shells inside the container;
> 
>   * make the code more maintainable by using a couple of classes.
> 
> 
> [v2] https://listman.redhat.com/archives/libvir-list/2021-February/msg00922.html
> [v1] https://listman.redhat.com/archives/libvir-list/2021-February/msg00900.html

See my comments on a few of the patches, but overall, I like this, so:
Reviewed-by: Erik Skultety <eskultet@redhat.com>