[v1] target/mips: Deprecate Trap-and-Emul KVM support

[PATCH] target/mips: Deprecate Trap-and-Emul KVM support

Posted by Jiaxun Yang 3 years, 1 month ago

Upstream kernel had removed both host[1] and guest[2] support.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=45c7e8af4a5e3f0bea4ac209eea34118dd57ac64
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=a1515ec7204edca770c07929df8538fcdb03ad46

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 docs/system/deprecated.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index cfabe69846..a409c65485 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -496,3 +496,11 @@ nanoMIPS ISA
 
 The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain.
 As it is hard to generate binaries for it, declare it deprecated.
+
+KVM features
+-------------------
+
+MIPS Trap-and-Emul KVM support
+
+The MIPS ``Trap-and-Emul`` KVM host and guest support has been removed
+from upstream kernel, declare it deprecated.
-- 
2.30.1

Re: [PATCH] target/mips: Deprecate Trap-and-Emul KVM support

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

+Paolo/Thomas/KVM

On 3/12/21 2:03 AM, Jiaxun Yang wrote:
> Upstream kernel had removed both host[1] and guest[2] support.
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=45c7e8af4a5e3f0bea4ac209eea34118dd57ac64
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=a1515ec7204edca770c07929df8538fcdb03ad46
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  docs/system/deprecated.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index cfabe69846..a409c65485 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -496,3 +496,11 @@ nanoMIPS ISA
>  
>  The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain.
>  As it is hard to generate binaries for it, declare it deprecated.
> +
> +KVM features
> +-------------------

"------------" else Sphinx complains.

> +
> +MIPS Trap-and-Emul KVM support

Missing "since which release" information.

> +
> +The MIPS ``Trap-and-Emul`` KVM host and guest support has been removed
> +from upstream kernel, declare it deprecated.
> 

What about adding an accelerator section and add this as a sub-section?

-- >8 --
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index a4515d8acd3..9c702a4ea7b 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -292,6 +292,15 @@ The ``acl_show``, ``acl_reset``, ``acl_policy``,
``acl_add``, and
 ``acl_remove`` commands are deprecated with no replacement. Authorization
 for VNC should be performed using the pluggable QAuthZ objects.

+System accelerators
+-------------------
+
+MIPS ``Trap-and-Emul`` KVM support (since 6.0)
+''''''''''''''''''''''''''''''''''''''''''''''
+
+The MIPS ``Trap-and-Emul`` KVM host and guest support has been removed
+from upstream kernel, declare it deprecated.
+
 System emulator CPUS
 --------------------

---

Re: [PATCH] target/mips: Deprecate Trap-and-Emul KVM support

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

Jiaxun, ping for moving the section?

On 3/12/21 10:43 AM, Philippe Mathieu-Daudé wrote:
> +Paolo/Thomas/KVM
> 
> On 3/12/21 2:03 AM, Jiaxun Yang wrote:
>> Upstream kernel had removed both host[1] and guest[2] support.
>>
>> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=45c7e8af4a5e3f0bea4ac209eea34118dd57ac64
>> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=a1515ec7204edca770c07929df8538fcdb03ad46
>>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>  docs/system/deprecated.rst | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
>> index cfabe69846..a409c65485 100644
>> --- a/docs/system/deprecated.rst
>> +++ b/docs/system/deprecated.rst
>> @@ -496,3 +496,11 @@ nanoMIPS ISA
>>  
>>  The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain.
>>  As it is hard to generate binaries for it, declare it deprecated.
>> +
>> +KVM features
>> +-------------------
> 
> "------------" else Sphinx complains.
> 
>> +
>> +MIPS Trap-and-Emul KVM support
> 
> Missing "since which release" information.
> 
>> +
>> +The MIPS ``Trap-and-Emul`` KVM host and guest support has been removed
>> +from upstream kernel, declare it deprecated.
>>
> 
> What about adding an accelerator section and add this as a sub-section?
> 
> -- >8 --
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index a4515d8acd3..9c702a4ea7b 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -292,6 +292,15 @@ The ``acl_show``, ``acl_reset``, ``acl_policy``,
> ``acl_add``, and
>  ``acl_remove`` commands are deprecated with no replacement. Authorization
>  for VNC should be performed using the pluggable QAuthZ objects.
> 
> +System accelerators
> +-------------------
> +
> +MIPS ``Trap-and-Emul`` KVM support (since 6.0)
> +''''''''''''''''''''''''''''''''''''''''''''''
> +
> +The MIPS ``Trap-and-Emul`` KVM host and guest support has been removed
> +from upstream kernel, declare it deprecated.
> +
>  System emulator CPUS
>  --------------------
> 
> ---
>