spec: Drop BuildDepends on make

[libvirt PATCH] spec: Drop BuildDepends on make

Andrea Bolognani posted 1 patch 3 years, 1 month ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210311143351.17580-1-abologna@redhat.com

libvirt.spec.in       | 1 -
mingw-libvirt.spec.in | 1 -
2 files changed, 2 deletions(-)

Expand all Fold all

[libvirt PATCH] spec: Drop BuildDepends on make

Posted by Andrea Bolognani 3 years, 1 month ago

make is only used for the syntax-check tests, which we are
explicitly skipping when building RPMs.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in       | 1 -
 mingw-libvirt.spec.in | 1 -
 2 files changed, 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 8d8b900fbb..f9af330186 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -266,7 +266,6 @@ BuildRequires: python3-docutils
 BuildRequires: gcc
 BuildRequires: meson >= 0.54.0
 BuildRequires: ninja-build
-BuildRequires: make
 BuildRequires: git
 %if 0%{?fedora} || 0%{?rhel} > 7
 BuildRequires: perl-interpreter
diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index 0686cbaf78..288f533d52 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -54,7 +54,6 @@ BuildRequires:  libxslt
 BuildRequires:  python3
 BuildRequires:  perl-interpreter
 BuildRequires:  perl(Getopt::Long)
-BuildRequires:  make
 BuildRequires:  meson
 BuildRequires:  ninja-build
 BuildRequires: python3-docutils
-- 
2.26.2

Re: [libvirt PATCH] spec: Drop BuildDepends on make

Posted by Ján Tomko 3 years, 1 month ago

On a Thursday in 2021, Andrea Bolognani wrote:
>make is only used for the syntax-check tests, which we are
>explicitly skipping when building RPMs.
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> libvirt.spec.in       | 1 -
> mingw-libvirt.spec.in | 1 -
> 2 files changed, 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano