qemu: Only raise memlock limit if necessary

[libvirt PATCH v2 0/4] qemu: Only raise memlock limit if necessary

Andrea Bolognani posted 4 patches 3 years, 1 month ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210309134709.44613-1-abologna@redhat.com

src/qemu/qemu_domain.c |  36 +++++++++------
src/util/virprocess.c  | 102 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 125 insertions(+), 13 deletions(-)

Expand all Fold all

[libvirt PATCH v2 0/4] qemu: Only raise memlock limit if necessary

Posted by Andrea Bolognani 3 years, 1 month ago

This feature has been requested by KubeVirt developers and will make
it possible for them to make some VFIO-related features, such as
migration and hotplug, work correctly.

  https://bugzilla.redhat.com/show_bug.cgi?id=1916346

Changes from [v1]:

  * prep patches have been pushed;

  * parsing /proc file is now explicitly restricted to Linux only
    and only uses safe libvirt helpers;

  * the qemu.conf knob has been dropped in favor of adopting a
    behavior that should work correctly in all scenarios.

[v1] https://listman.redhat.com/archives/libvir-list/2021-March/msg00293.html

Andrea Bolognani (4):
  util: Try to get limits from /proc
  qemu: Don't ignore virProcessGetMaxMemLock() errors
  qemu: Refactor qemuDomainAdjustMaxMemLock()
  qemu: Only raise memlock limit if necessary

 src/qemu/qemu_domain.c |  36 +++++++++------
 src/util/virprocess.c  | 102 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 125 insertions(+), 13 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH v2 0/4] qemu: Only raise memlock limit if necessary

Posted by Michal Privoznik 3 years, 1 month ago

On 3/9/21 2:47 PM, Andrea Bolognani wrote:
> This feature has been requested by KubeVirt developers and will make
> it possible for them to make some VFIO-related features, such as
> migration and hotplug, work correctly.
> 
>    https://bugzilla.redhat.com/show_bug.cgi?id=1916346
> 
> Changes from [v1]:
> 
>    * prep patches have been pushed;
> 
>    * parsing /proc file is now explicitly restricted to Linux only
>      and only uses safe libvirt helpers;
> 
>    * the qemu.conf knob has been dropped in favor of adopting a
>      behavior that should work correctly in all scenarios.
> 
> [v1] https://listman.redhat.com/archives/libvir-list/2021-March/msg00293.html
> 
> Andrea Bolognani (4):
>    util: Try to get limits from /proc
>    qemu: Don't ignore virProcessGetMaxMemLock() errors
>    qemu: Refactor qemuDomainAdjustMaxMemLock()
>    qemu: Only raise memlock limit if necessary
> 
>   src/qemu/qemu_domain.c |  36 +++++++++------
>   src/util/virprocess.c  | 102 +++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 125 insertions(+), 13 deletions(-)
> 

If you fix small nits in 1/4 then:

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal