[v1] ui: add support for 'secret' object to provide VNC/SPICE passwords

[PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords

Posted by Daniel P. Berrangé 3 years, 2 months ago

This fixes a long standing limitation of the VNC/SPICE code which was
unable to securely accept passswords on the CLI, instead requiring use
of separate monitor commands after startup.

This takes the opportunity to also remove previously deprecated ACL
functionality from VNC.

Daniel P. Berrangé (4):
  ui: introduce "password-secret" option for VNC servers
  ui: introduce "password-secret" option for SPICE server
  ui: deprecate "password" option for SPICE server
  ui, monitor: remove deprecated VNC ACL option and HMP commands

 docs/system/deprecated.rst       |  24 ++--
 docs/system/removed-features.rst |  13 +++
 hmp-commands.hx                  |  76 -------------
 monitor/misc.c                   | 187 -------------------------------
 qemu-options.hx                  |  17 ++-
 ui/spice-core.c                  |  32 +++++-
 ui/vnc.c                         |  61 ++++------
 7 files changed, 88 insertions(+), 322 deletions(-)

-- 
2.29.2

Re: [PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords

Posted by Daniel P. Berrangé 3 years, 1 month ago

Ping

On Fri, Feb 19, 2021 at 06:45:52PM +0000, Daniel P. Berrangé wrote:
> This fixes a long standing limitation of the VNC/SPICE code which was
> unable to securely accept passswords on the CLI, instead requiring use
> of separate monitor commands after startup.
> 
> This takes the opportunity to also remove previously deprecated ACL
> functionality from VNC.
> 
> Daniel P. Berrangé (4):
>   ui: introduce "password-secret" option for VNC servers
>   ui: introduce "password-secret" option for SPICE server
>   ui: deprecate "password" option for SPICE server
>   ui, monitor: remove deprecated VNC ACL option and HMP commands
> 
>  docs/system/deprecated.rst       |  24 ++--
>  docs/system/removed-features.rst |  13 +++
>  hmp-commands.hx                  |  76 -------------
>  monitor/misc.c                   | 187 -------------------------------
>  qemu-options.hx                  |  17 ++-
>  ui/spice-core.c                  |  32 +++++-
>  ui/vnc.c                         |  61 ++++------
>  7 files changed, 88 insertions(+), 322 deletions(-)
> 
> -- 
> 2.29.2
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords

Posted by Gerd Hoffmann 3 years, 1 month ago

On Thu, Mar 11, 2021 at 10:37:45AM +0000, Daniel P. Berrangé wrote:
> Ping

Looks good but doesn't apply cleanly, can you rebase?

(current ui queue is gitlab.com/kraxel/qemu queue/ui, there are no
spice/vnc changes queued so it probably doesn't make a difference
compared to latest master)

take care,
  Gerd

Re: [PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords

Posted by Daniel P. Berrangé 3 years, 1 month ago

On Thu, Mar 11, 2021 at 12:13:42PM +0100, Gerd Hoffmann wrote:
> On Thu, Mar 11, 2021 at 10:37:45AM +0000, Daniel P. Berrangé wrote:
> > Ping
> 
> Looks good but doesn't apply cleanly, can you rebase?
> 
> (current ui queue is gitlab.com/kraxel/qemu queue/ui, there are no
> spice/vnc changes queued so it probably doesn't make a difference
> compared to latest master)

Sure, will rebase to master and check it also applies to this queue
cleanly.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|