1. Patchew
  2. Libvirt
  3. View series

[libvirt PATCH 0/5] qemu: more cleanup of boolean option handling

Daniel P. Berrangé posted 5 patches 3 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210216125705.275788-1-berrange@redhat.com
mode change 120000 =3D> 100644 tests/qemuxml2argvdata/user-aliases2.args
[libvirt PATCH 0/5] qemu: more cleanup of boolean option handling
Posted by Daniel P. Berrangé 3 years, 2 months ago 
This completes the conversion to standarize on on|off for all boolean
options in QEMU.

Daniel P. Berrang=C3=A9 (5):
  qemu: probe for -vnc supporting use of QemuOpts syntax
  qemu: use on|off for -vnc boolean option values
  qemu: use on|off instead of yes|no for -object boolean properties
  qemu: use on|off instead of yes|no for -drive boolean properties
  qemu: remove support for generating yes|no boolean options

 src/qemu/qemu_capabilities.c                  |   2 +
 src/qemu/qemu_capabilities.h                  |   1 +
 src/qemu/qemu_command.c                       |  18 +-
 src/util/virqemu.c                            |  50 ++----
 src/util/virqemu.h                            |  10 +-
 .../caps_2.10.0.aarch64.xml                   |   1 +
 .../caps_2.10.0.ppc64.xml                     |   1 +
 .../caps_2.10.0.s390x.xml                     |   1 +
 .../caps_2.10.0.x86_64.xml                    |   1 +
 .../caps_2.11.0.s390x.xml                     |   1 +
 .../caps_2.11.0.x86_64.xml                    |   1 +
 .../caps_2.12.0.aarch64.xml                   |   1 +
 .../caps_2.12.0.ppc64.xml                     |   1 +
 .../caps_2.12.0.s390x.xml                     |   1 +
 .../caps_2.12.0.x86_64.xml                    |   1 +
 .../caps_2.4.0.x86_64.xml                     |   1 +
 .../caps_2.5.0.x86_64.xml                     |   1 +
 .../caps_2.6.0.aarch64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml |   1 +
 .../caps_2.6.0.x86_64.xml                     |   1 +
 .../qemucapabilitiesdata/caps_2.7.0.s390x.xml |   1 +
 .../caps_2.7.0.x86_64.xml                     |   1 +
 .../qemucapabilitiesdata/caps_2.8.0.s390x.xml |   1 +
 .../caps_2.8.0.x86_64.xml                     |   1 +
 .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml |   1 +
 .../qemucapabilitiesdata/caps_2.9.0.s390x.xml |   1 +
 .../caps_2.9.0.x86_64.xml                     |   1 +
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |   1 +
 .../caps_3.0.0.riscv32.xml                    |   1 +
 .../caps_3.0.0.riscv64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |   1 +
 .../caps_3.0.0.x86_64.xml                     |   1 +
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |   1 +
 .../caps_3.1.0.x86_64.xml                     |   1 +
 .../caps_4.0.0.aarch64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |   1 +
 .../caps_4.0.0.riscv32.xml                    |   1 +
 .../caps_4.0.0.riscv64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_4.0.0.s390x.xml |   1 +
 .../caps_4.0.0.x86_64.xml                     |   1 +
 .../caps_4.1.0.x86_64.xml                     |   1 +
 .../caps_4.2.0.aarch64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |   1 +
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |   1 +
 .../caps_4.2.0.x86_64.xml                     |   1 +
 .../caps_5.0.0.aarch64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   1 +
 .../caps_5.0.0.riscv64.xml                    |   1 +
 .../caps_5.0.0.x86_64.xml                     |   1 +
 .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |   1 +
 .../caps_5.1.0.x86_64.xml                     |   1 +
 .../caps_5.2.0.aarch64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |   1 +
 .../caps_5.2.0.riscv64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |   1 +
 .../caps_5.2.0.x86_64.xml                     |   1 +
 .../caps_6.0.0.x86_64.xml                     |   1 +
 tests/qemucommandutiltest.c                   |  10 +-
 .../aarch64-gic-default-both.args             |  28 ++-
 .../aarch64-gic-default-v2.args               |  28 ++-
 .../aarch64-gic-default-v3.args               |  28 ++-
 .../qemuxml2argvdata/aarch64-gic-default.args |  28 ++-
 .../aarch64-gic-none-both.args                |  28 ++-
 .../qemuxml2argvdata/aarch64-gic-none-v2.args |  28 ++-
 .../qemuxml2argvdata/aarch64-gic-none-v3.args |  28 ++-
 tests/qemuxml2argvdata/aarch64-gic-none.args  |  28 ++-
 tests/qemuxml2argvdata/cpu-check-full.args    |  30 +++-
 tests/qemuxml2argvdata/cpu-check-partial.args |  30 +++-
 .../qemuxml2argvdata/cpu-numa-memshared.args  |   4 +-
 ...sk-backing-chains-index.x86_64-2.12.0.args |  62 ++++++-
 ...sk-backing-chains-index.x86_64-latest.args | 169 +++++++++++++++++-
 ...isk-network-tlsx509-nbd.x86_64-2.12.0.args |   2 +-
 ...isk-network-tlsx509-nbd.x86_64-latest.args |   2 +-
 ...sk-network-tlsx509-vxhs.x86_64-2.12.0.args |   4 +-
 ...isk-network-tlsx509-vxhs.x86_64-5.0.0.args |   4 +-
 .../disk-network-tlsx509.x86_64-2.12.0.args   |   6 +-
 .../disk-network-tlsx509.x86_64-latest.args   |   6 +-
 .../disk-vhostuser.x86_64-latest.args         |   4 +-
 .../fd-memory-numa-topology.args              |   2 +-
 .../fd-memory-numa-topology2.args             |   4 +-
 .../fd-memory-numa-topology3.args             |   6 +-
 ...graphics-vnc-tls-secret.x86_64-latest.args |   4 +-
 .../graphics-vnc-tls.x86_64-2.4.0.args        |   2 +-
 .../graphics-vnc-tls.x86_64-latest.args       |   4 +-
 .../qemuxml2argvdata/hugepages-memaccess.args |  10 +-
 .../hugepages-memaccess2.args                 |  10 +-
 .../hugepages-memaccess3.x86_64-latest.args   |   4 +-
 .../hugepages-numa-nodeset-part.args          |   2 +-
 .../hugepages-numa-nodeset.args               |   8 +-
 .../hugepages-nvdimm.x86_64-latest.args       |   6 +-
 tests/qemuxml2argvdata/hugepages-shared.args  |   8 +-
 .../mach-virt-console-native.args             |  29 ++-
 .../mach-virt-serial+console-native.args      |  29 ++-
 .../mach-virt-serial-compat.args              |  29 ++-
 ...memory-default-hugepage.x86_64-latest.args |   4 +-
 .../memfd-memory-numa.x86_64-latest.args      |   4 +-
 .../memory-hotplug-dimm-addr.args             |   2 +-
 .../qemuxml2argvdata/memory-hotplug-dimm.args |   2 +-
 ...y-hotplug-nvdimm-access.x86_64-latest.args |   4 +-
 ...ry-hotplug-nvdimm-align.x86_64-latest.args |   4 +-
 ...ry-hotplug-nvdimm-label.x86_64-latest.args |   4 +-
 ...ory-hotplug-nvdimm-pmem.x86_64-latest.args |   4 +-
 ...emory-hotplug-nvdimm-ppc64-abi-update.args |   2 +-
 .../memory-hotplug-nvdimm-ppc64.args          |   2 +-
 ...hotplug-nvdimm-readonly.x86_64-latest.args |   4 +-
 .../memory-hotplug-nvdimm.x86_64-latest.args  |   2 +-
 ...ory-hotplug-virtio-pmem.x86_64-latest.args |   2 +-
 .../qemuxml2argvdata/pages-dimm-discard.args  |   4 +-
 .../pci-rom-disabled-invalid.args             |  30 +++-
 .../pseries-console-native.args               |  28 ++-
 .../pseries-serial+console-native.args        |  28 ++-
 .../pseries-serial-compat.args                |  28 ++-
 .../serial-tcp-tlsx509-chardev-verify.args    |   2 +-
 .../serial-tcp-tlsx509-chardev.args           |   2 +-
 .../serial-tcp-tlsx509-secret-chardev.args    |   2 +-
 .../shmem-plain-doorbell.args                 |   6 +-
 tests/qemuxml2argvdata/user-aliases.args      |   8 +-
 tests/qemuxml2argvdata/user-aliases2.args     |  29 ++-
 ...vhost-user-fs-fd-memory.x86_64-latest.args |   2 +-
 ...vhost-user-fs-hugepages.x86_64-latest.args |   2 +-
 ...host-user-gpu-secondary.x86_64-latest.args |   2 +-
 .../vhost-user-vga.x86_64-latest.args         |   2 +-
 122 files changed, 906 insertions(+), 156 deletions(-)
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/aarch64-gic-default-bo=
th.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/aarch64-gic-default-v2=
.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/aarch64-gic-default-v3=
.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/aarch64-gic-default.ar=
gs
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/aarch64-gic-none-both.=
args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/aarch64-gic-none-v2.ar=
gs
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/aarch64-gic-none-v3.ar=
gs
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/aarch64-gic-none.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/cpu-check-full.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/cpu-check-partial.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/disk-backing-chains-in=
dex.x86_64-2.12.0.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/disk-backing-chains-in=
dex.x86_64-latest.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/mach-virt-console-nati=
ve.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/mach-virt-serial+conso=
le-native.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/mach-virt-serial-compa=
t.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pci-rom-disabled-inval=
id.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-console-native=
.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-serial+console=
-native.args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-serial-compat.=
args
 mode change 120000 =3D> 100644 tests/qemuxml2argvdata/user-aliases2.args

--=20
2.29.2
Re: [libvirt PATCH 0/5] qemu: more cleanup of boolean option handling
Posted by Peter Krempa 3 years, 2 months ago 
On Tue, Feb 16, 2021 at 12:57:00 +0000, Daniel Berrange wrote:
> This completes the conversion to standarize on on|off for all boolean
> options in QEMU.
> 
> Daniel P. Berrang=C3=A9 (5):
>   qemu: probe for -vnc supporting use of QemuOpts syntax
>   qemu: use on|off for -vnc boolean option values
>   qemu: use on|off instead of yes|no for -object boolean properties
>   qemu: use on|off instead of yes|no for -drive boolean properties
>   qemu: remove support for generating yes|no boolean options

Series:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

if you don't expand output files unnecessarily in 3/5

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.