[PATCH RESEND 00/20] handle missing SR-IOV VF hostdevs during running domains

Daniel Henrique Barboza posted 20 patches 3 years, 3 months ago
Test syntax-check failed
Failed in applying to current master (apply log)
include/libvirt/libvirt-nodedev.h  |  2 +-
src/conf/domain_audit.c            |  6 +-
src/datatypes.h                    |  2 +
src/hypervisor/domain_driver.c     | 30 ++++++++++
src/hypervisor/domain_driver.h     |  4 ++
src/hypervisor/virhostdev.c        | 88 ++++++++++++++++++++++------
src/hypervisor/virhostdev.h        |  2 +
src/libvirt-nodedev.c              | 15 +++--
src/libvirt_private.syms           |  3 +
src/libxl/libxl_driver.c           | 87 ++++++++--------------------
src/node_device/node_device_udev.c | 11 ++--
src/qemu/qemu_cgroup.c             | 10 ++++
src/qemu/qemu_domain_address.c     |  5 +-
src/qemu/qemu_driver.c             | 81 +++++++-------------------
src/security/security_apparmor.c   |  3 +-
src/security/security_dac.c        | 61 ++++++++------------
src/security/security_selinux.c    | 66 +++++++++------------
src/security/virt-aa-helper.c      |  6 +-
src/util/virnetdev.c               |  3 +-
src/util/virnvme.c                 |  5 +-
src/util/virpci.c                  | 93 ++++++++++++++----------------
src/util/virpci.h                  | 14 ++---
tests/virhostdevtest.c             |  3 +-
tests/virpcitest.c                 | 35 ++++++++---
tools/virsh-domain.c               | 18 ++----
25 files changed, 325 insertions(+), 328 deletions(-)
[PATCH RESEND 00/20] handle missing SR-IOV VF hostdevs during running domains
Posted by Daniel Henrique Barboza 3 years, 3 months ago
This is the rebased version of

https://www.redhat.com/archives/libvir-list/2021-January/msg00028.html

with master at 57b1ddcaaa5b5. No changes made aside from trivial conflicts
fixes.

I also removed the military jargon from the previous subject to make it
clear what this series is doing.

Daniel Henrique Barboza (20):
  virpci, domain_audit: use virPCIDeviceAddressAsString()
  qemu, lxc: move NodeDeviceGetPCIInfo() function to domain_driver.c
  domain_driver.c: use PCI address with
    virDomainDriverNodeDeviceGetPCIInfo()
  virpci.c: simplify virPCIDeviceNew() signature
  virpci: introduce virPCIDeviceExists()
  virhostdev.c: virHostdevGetPCIHostDevice() now reports missing device
  security_selinux.c: modernize set/restore hostdev subsys label
    functions
  security_dac.c: modernize hostdev label set/restore functions
  dac, selinux: skip setting/restoring label for absent PCI devices
  libvirt-nodedev.c: remove return value from virNodeDeviceFree()
  qemu_driver.c: modernize qemuNodeDeviceReAttach()
  libxl_driver.c: modernize libxlNodeDeviceReAttach()
  virsh-domain.c: modernize cmdDetachDevice()
  virhostdev.c: add virHostdevIsPCIDevice() helper
  qemu_cgroup.c: skip absent PCI devices in qemuTeardownHostdevCgroup()
  virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListFindIndex()
  virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListFind()
  virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListSteal()
  virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListDel()
  virhostdev.c: remove missing PCI devs from hostdev manager

 include/libvirt/libvirt-nodedev.h  |  2 +-
 src/conf/domain_audit.c            |  6 +-
 src/datatypes.h                    |  2 +
 src/hypervisor/domain_driver.c     | 30 ++++++++++
 src/hypervisor/domain_driver.h     |  4 ++
 src/hypervisor/virhostdev.c        | 88 ++++++++++++++++++++++------
 src/hypervisor/virhostdev.h        |  2 +
 src/libvirt-nodedev.c              | 15 +++--
 src/libvirt_private.syms           |  3 +
 src/libxl/libxl_driver.c           | 87 ++++++++--------------------
 src/node_device/node_device_udev.c | 11 ++--
 src/qemu/qemu_cgroup.c             | 10 ++++
 src/qemu/qemu_domain_address.c     |  5 +-
 src/qemu/qemu_driver.c             | 81 +++++++-------------------
 src/security/security_apparmor.c   |  3 +-
 src/security/security_dac.c        | 61 ++++++++------------
 src/security/security_selinux.c    | 66 +++++++++------------
 src/security/virt-aa-helper.c      |  6 +-
 src/util/virnetdev.c               |  3 +-
 src/util/virnvme.c                 |  5 +-
 src/util/virpci.c                  | 93 ++++++++++++++----------------
 src/util/virpci.h                  | 14 ++---
 tests/virhostdevtest.c             |  3 +-
 tests/virpcitest.c                 | 35 ++++++++---
 tools/virsh-domain.c               | 18 ++----
 25 files changed, 325 insertions(+), 328 deletions(-)

-- 
2.26.2

Re: [PATCH RESEND 00/20] handle missing SR-IOV VF hostdevs during running domains
Posted by Daniel Henrique Barboza 3 years, 2 months ago
Laine,


I ended up pushing patches 1-4 and 7-8 (after applying your review
suggestions, of course) because I wanted to posted another series that
were dependent on some of these patches.

Patch 5 wasn't pushed because its first use is done on patch 06 and it
doesn't make sense to push it standalone.


Thanks,


DHB


On 1/18/21 4:53 PM, Daniel Henrique Barboza wrote:
> This is the rebased version of
> 
> https://www.redhat.com/archives/libvir-list/2021-January/msg00028.html
> 
> with master at 57b1ddcaaa5b5. No changes made aside from trivial conflicts
> fixes.
> 
> I also removed the military jargon from the previous subject to make it
> clear what this series is doing.
> 
> Daniel Henrique Barboza (20):
>    virpci, domain_audit: use virPCIDeviceAddressAsString()
>    qemu, lxc: move NodeDeviceGetPCIInfo() function to domain_driver.c
>    domain_driver.c: use PCI address with
>      virDomainDriverNodeDeviceGetPCIInfo()
>    virpci.c: simplify virPCIDeviceNew() signature
>    virpci: introduce virPCIDeviceExists()
>    virhostdev.c: virHostdevGetPCIHostDevice() now reports missing device
>    security_selinux.c: modernize set/restore hostdev subsys label
>      functions
>    security_dac.c: modernize hostdev label set/restore functions
>    dac, selinux: skip setting/restoring label for absent PCI devices
>    libvirt-nodedev.c: remove return value from virNodeDeviceFree()
>    qemu_driver.c: modernize qemuNodeDeviceReAttach()
>    libxl_driver.c: modernize libxlNodeDeviceReAttach()
>    virsh-domain.c: modernize cmdDetachDevice()
>    virhostdev.c: add virHostdevIsPCIDevice() helper
>    qemu_cgroup.c: skip absent PCI devices in qemuTeardownHostdevCgroup()
>    virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListFindIndex()
>    virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListFind()
>    virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListSteal()
>    virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListDel()
>    virhostdev.c: remove missing PCI devs from hostdev manager
> 
>   include/libvirt/libvirt-nodedev.h  |  2 +-
>   src/conf/domain_audit.c            |  6 +-
>   src/datatypes.h                    |  2 +
>   src/hypervisor/domain_driver.c     | 30 ++++++++++
>   src/hypervisor/domain_driver.h     |  4 ++
>   src/hypervisor/virhostdev.c        | 88 ++++++++++++++++++++++------
>   src/hypervisor/virhostdev.h        |  2 +
>   src/libvirt-nodedev.c              | 15 +++--
>   src/libvirt_private.syms           |  3 +
>   src/libxl/libxl_driver.c           | 87 ++++++++--------------------
>   src/node_device/node_device_udev.c | 11 ++--
>   src/qemu/qemu_cgroup.c             | 10 ++++
>   src/qemu/qemu_domain_address.c     |  5 +-
>   src/qemu/qemu_driver.c             | 81 +++++++-------------------
>   src/security/security_apparmor.c   |  3 +-
>   src/security/security_dac.c        | 61 ++++++++------------
>   src/security/security_selinux.c    | 66 +++++++++------------
>   src/security/virt-aa-helper.c      |  6 +-
>   src/util/virnetdev.c               |  3 +-
>   src/util/virnvme.c                 |  5 +-
>   src/util/virpci.c                  | 93 ++++++++++++++----------------
>   src/util/virpci.h                  | 14 ++---
>   tests/virhostdevtest.c             |  3 +-
>   tests/virpcitest.c                 | 35 ++++++++---
>   tools/virsh-domain.c               | 18 ++----
>   25 files changed, 325 insertions(+), 328 deletions(-)
> 

Re: [PATCH RESEND 00/20] handle missing SR-IOV VF hostdevs during running domains
Posted by Daniel Henrique Barboza 3 years, 2 months ago
Ping for reviews (patches 1-4 and 7-8 already pushed).



On 1/18/21 4:53 PM, Daniel Henrique Barboza wrote:
> This is the rebased version of
> 
> https://www.redhat.com/archives/libvir-list/2021-January/msg00028.html
> 
> with master at 57b1ddcaaa5b5. No changes made aside from trivial conflicts
> fixes.
> 
> I also removed the military jargon from the previous subject to make it
> clear what this series is doing.
> 
> Daniel Henrique Barboza (20):
>    virpci, domain_audit: use virPCIDeviceAddressAsString()
>    qemu, lxc: move NodeDeviceGetPCIInfo() function to domain_driver.c
>    domain_driver.c: use PCI address with
>      virDomainDriverNodeDeviceGetPCIInfo()
>    virpci.c: simplify virPCIDeviceNew() signature
>    virpci: introduce virPCIDeviceExists()
>    virhostdev.c: virHostdevGetPCIHostDevice() now reports missing device
>    security_selinux.c: modernize set/restore hostdev subsys label
>      functions
>    security_dac.c: modernize hostdev label set/restore functions
>    dac, selinux: skip setting/restoring label for absent PCI devices
>    libvirt-nodedev.c: remove return value from virNodeDeviceFree()
>    qemu_driver.c: modernize qemuNodeDeviceReAttach()
>    libxl_driver.c: modernize libxlNodeDeviceReAttach()
>    virsh-domain.c: modernize cmdDetachDevice()
>    virhostdev.c: add virHostdevIsPCIDevice() helper
>    qemu_cgroup.c: skip absent PCI devices in qemuTeardownHostdevCgroup()
>    virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListFindIndex()
>    virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListFind()
>    virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListSteal()
>    virpci.c: use virPCIDeviceAddressPtr in virPCIDeviceListDel()
>    virhostdev.c: remove missing PCI devs from hostdev manager
> 
>   include/libvirt/libvirt-nodedev.h  |  2 +-
>   src/conf/domain_audit.c            |  6 +-
>   src/datatypes.h                    |  2 +
>   src/hypervisor/domain_driver.c     | 30 ++++++++++
>   src/hypervisor/domain_driver.h     |  4 ++
>   src/hypervisor/virhostdev.c        | 88 ++++++++++++++++++++++------
>   src/hypervisor/virhostdev.h        |  2 +
>   src/libvirt-nodedev.c              | 15 +++--
>   src/libvirt_private.syms           |  3 +
>   src/libxl/libxl_driver.c           | 87 ++++++++--------------------
>   src/node_device/node_device_udev.c | 11 ++--
>   src/qemu/qemu_cgroup.c             | 10 ++++
>   src/qemu/qemu_domain_address.c     |  5 +-
>   src/qemu/qemu_driver.c             | 81 +++++++-------------------
>   src/security/security_apparmor.c   |  3 +-
>   src/security/security_dac.c        | 61 ++++++++------------
>   src/security/security_selinux.c    | 66 +++++++++------------
>   src/security/virt-aa-helper.c      |  6 +-
>   src/util/virnetdev.c               |  3 +-
>   src/util/virnvme.c                 |  5 +-
>   src/util/virpci.c                  | 93 ++++++++++++++----------------
>   src/util/virpci.h                  | 14 ++---
>   tests/virhostdevtest.c             |  3 +-
>   tests/virpcitest.c                 | 35 ++++++++---
>   tools/virsh-domain.c               | 18 ++----
>   25 files changed, 325 insertions(+), 328 deletions(-)
> 

Re: [PATCH RESEND 00/20] handle missing SR-IOV VF hostdevs during running domains
Posted by Laine Stump 3 years, 2 months ago
On 2/16/21 8:16 AM, Daniel Henrique Barboza wrote:
> Ping for reviews (patches 1-4 and 7-8 already pushed).
>

Yeah, sorry. It's been on my list ever since I left it half-finished, 
but I keep getting distra... OOHH LOOK!!! SOMETHING SHINY!!!!!!!!!!



....

Okay, back to the subject - I promise I will go back to these before 
today is finished!!