[PATCH v2] spec: Add the man pages of split daemons

Han Han posted 1 patch 3 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210116071618.74780-1-hhan@redhat.com
libvirt.spec.in | 10 ++++++++++
1 file changed, 10 insertions(+)
[PATCH v2] spec: Add the man pages of split daemons
Posted by Han Han 3 years, 3 months ago
Fix the errors from commit a7cafa7bc2 when build RPMs from spec file:
error: Installed (but unpackaged) file(s) found:
   /usr/share/man/man8/virtinterfaced.8.gz
   /usr/share/man/man8/virtlxcd.8.gz
   /usr/share/man/man8/virtnetworkd.8.gz
   /usr/share/man/man8/virtnodedevd.8.gz
   /usr/share/man/man8/virtnwfilterd.8.gz
   /usr/share/man/man8/virtproxyd.8.gz
   /usr/share/man/man8/virtqemud.8.gz
   /usr/share/man/man8/virtsecretd.8.gz
   /usr/share/man/man8/virtstoraged.8.gz
   /usr/share/man/man8/virtvboxd.8.gz
   /usr/share/man/man8/virtxend.8.gz

Signed-off-by: Han Han <hhan@redhat.com>
---
Diff from v1: remove man page for virtvzd and virtbhyved
---
 libvirt.spec.in | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index b5892987cf..9458a7a02f 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1581,6 +1581,16 @@ exit 0
 %{_mandir}/man8/virtlogd.8*
 %{_mandir}/man8/virtlockd.8*
 %{_mandir}/man8/virtproxyd.8*
+%{_mandir}/man8/virtxend.8*
+%{_mandir}/man8/virtvboxd.8*
+%{_mandir}/man8/virtstoraged.8*
+%{_mandir}/man8/virtsecretd.8*
+%{_mandir}/man8/virtqemud.8*
+%{_mandir}/man8/virtnwfilterd.8*
+%{_mandir}/man8/virtnodedevd.8*
+%{_mandir}/man8/virtnetworkd.8*
+%{_mandir}/man8/virtlxcd.8*
+%{_mandir}/man8/virtinterfaced.8*
 %{_mandir}/man7/virkey*.7*
 
 %files daemon-config-network
-- 
2.29.2

Re: [PATCH v2] spec: Add the man pages of split daemons
Posted by Daniel P. Berrangé 3 years, 3 months ago
On Sat, Jan 16, 2021 at 03:16:18PM +0800, Han Han wrote:
> Fix the errors from commit a7cafa7bc2 when build RPMs from spec file:
> error: Installed (but unpackaged) file(s) found:
>    /usr/share/man/man8/virtinterfaced.8.gz
>    /usr/share/man/man8/virtlxcd.8.gz
>    /usr/share/man/man8/virtnetworkd.8.gz
>    /usr/share/man/man8/virtnodedevd.8.gz
>    /usr/share/man/man8/virtnwfilterd.8.gz
>    /usr/share/man/man8/virtproxyd.8.gz
>    /usr/share/man/man8/virtqemud.8.gz
>    /usr/share/man/man8/virtsecretd.8.gz
>    /usr/share/man/man8/virtstoraged.8.gz
>    /usr/share/man/man8/virtvboxd.8.gz
>    /usr/share/man/man8/virtxend.8.gz
> 
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
> Diff from v1: remove man page for virtvzd and virtbhyved
> ---
>  libvirt.spec.in | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index b5892987cf..9458a7a02f 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1581,6 +1581,16 @@ exit 0
>  %{_mandir}/man8/virtlogd.8*
>  %{_mandir}/man8/virtlockd.8*
>  %{_mandir}/man8/virtproxyd.8*
> +%{_mandir}/man8/virtxend.8*
> +%{_mandir}/man8/virtvboxd.8*
> +%{_mandir}/man8/virtstoraged.8*
> +%{_mandir}/man8/virtsecretd.8*
> +%{_mandir}/man8/virtqemud.8*
> +%{_mandir}/man8/virtnwfilterd.8*
> +%{_mandir}/man8/virtnodedevd.8*
> +%{_mandir}/man8/virtnetworkd.8*
> +%{_mandir}/man8/virtlxcd.8*
> +%{_mandir}/man8/virtinterfaced.8*
>  %{_mandir}/man7/virkey*.7*

This doesn't make any sense - those man pages are all listed already
against the individual sub-RPMs that contain the relevant daemon
binary.

$ grep man8/virt libvirt.spec.in 
%{_mandir}/man8/virtlogd.8*
%{_mandir}/man8/virtlockd.8*
%{_mandir}/man8/virtproxyd.8*
%{_mandir}/man8/virtinterfaced.8*
%{_mandir}/man8/virtnetworkd.8*
%{_mandir}/man8/virtnodedevd.8*
%{_mandir}/man8/virtnwfilterd.8*
%{_mandir}/man8/virtsecretd.8*
%{_mandir}/man8/virtstoraged.8*
%{_mandir}/man8/virtqemud.8*
%{_mandir}/man8/virtlxcd.8*
%{_mandir}/man8/virtxend.8*
%{_mandir}/man8/virtvboxd.8*
%{_mandir}/man8/virt-sanlock-cleanup.8*


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|