[v2] netlink: Extract common code to simplify netlink functions

[PATCHv2 0/4] netlink: Extract common code to simplify netlink functions

Shi Lei posted 4 patches 3 years, 3 months ago

Diff against v1 v3
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210106024017.42218-1-shi_lei@massclouds.com

There is a newer version of this series

src/util/virnetlink.c | 314 +++++++++++++++++++-----------------------
src/util/virnetlink.h |  27 +---
2 files changed, 142 insertions(+), 199 deletions(-)

Expand all Fold all

[PATCHv2 0/4] netlink: Extract common code to simplify netlink functions

Posted by Shi Lei 3 years, 3 months ago

V1 here: https://www.redhat.com/archives/libvir-list/2020-December/msg00836.html

Since V1:
    - Minor fixes for reporting system error in Patch 4.

Shi Lei (4):
  netlink: Remove invalid flags(NLM_F_CREATE and NLM_F_EXCL) for RTM_DELLINK
  netlink: Minor changes for macros NETLINK_MSG_[NEST_START|NEST_END|PUT]
  netlink: Introduce macro NETLINK_MSG_APPEND to wrap nlmsg_append
  netlink: Introduce a helper function to simplify netlink functions

 src/util/virnetlink.c | 314 +++++++++++++++++++-----------------------
 src/util/virnetlink.h |  27 +---
 2 files changed, 142 insertions(+), 199 deletions(-)

-- 
2.25.1

Re: [PATCHv2 0/4] netlink: Extract common code to simplify netlink functions

Posted by Daniel Henrique Barboza 3 years, 3 months ago


On 1/5/21 11:40 PM, Shi Lei wrote:
> V1 here: https://www.redhat.com/archives/libvir-list/2020-December/msg00836.html
> 
> Since V1:
>      - Minor fixes for reporting system error in Patch 4.
> 
> Shi Lei (4):
>    netlink: Remove invalid flags(NLM_F_CREATE and NLM_F_EXCL) for RTM_DELLINK
>    netlink: Minor changes for macros NETLINK_MSG_[NEST_START|NEST_END|PUT]
>    netlink: Introduce macro NETLINK_MSG_APPEND to wrap nlmsg_append
>    netlink: Introduce a helper function to simplify netlink functions
> 

Series LGTM

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   src/util/virnetlink.c | 314 +++++++++++++++++++-----------------------
>   src/util/virnetlink.h |  27 +---
>   2 files changed, 142 insertions(+), 199 deletions(-)
>