[v3] Use netlink to create veth device pair when netlink is supported

[PATCHv3 0/3] Use netlink to create veth device pair when netlink is supported

Shi Lei posted 3 patches 3 years, 4 months ago

Diff against v2
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201216060106.44120-1-shi_lei@massclouds.com

src/lxc/lxc_process.c    |   4 +-
src/util/virnetdevveth.c | 126 ++++++++++++++++++++++-----------------
src/util/virnetlink.c    |  14 +++++
src/util/virnetlink.h    |   1 +
4 files changed, 89 insertions(+), 56 deletions(-)

Expand all Fold all

[PATCHv3 0/3] Use netlink to create veth device pair when netlink is supported

Posted by Shi Lei 3 years, 4 months ago

V2 here: https://www.redhat.com/archives/libvir-list/2020-November/msg01239.html
Since V2:
    * Remove the argument 'status' of virNetDevVethCreateInternal
    * fix a memory leak in virLXCProcessSetupInterfaceTap

V1 here: https://www.redhat.com/archives/libvir-list/2020-November/msg00898.html
Since V1:
    * Include <linux/veth.h> rather than introducing enum VETH_INFO_*
    * Have complete functions within an #ifdefs rather than
      putting #ifdefs in function

Shi Lei (3):
  util:netlink: Enable virNetlinkNewLink to support veth
  util:veth: Create veth device pair by netlink
  lxc: fix a memory leak

 src/lxc/lxc_process.c    |   4 +-
 src/util/virnetdevveth.c | 126 ++++++++++++++++++++++-----------------
 src/util/virnetlink.c    |  14 +++++
 src/util/virnetlink.h    |   1 +
 4 files changed, 89 insertions(+), 56 deletions(-)

-- 
2.25.1

Re: [PATCHv3 0/3] Use netlink to create veth device pair when netlink is supported

Posted by Laine Stump 3 years, 4 months ago

On 12/16/20 1:01 AM, Shi Lei wrote:
> V2 here: https://www.redhat.com/archives/libvir-list/2020-November/msg01239.html
> Since V2:
>      * Remove the argument 'status' of virNetDevVethCreateInternal
>      * fix a memory leak in virLXCProcessSetupInterfaceTap
>
> V1 here: https://www.redhat.com/archives/libvir-list/2020-November/msg00898.html
> Since V1:
>      * Include <linux/veth.h> rather than introducing enum VETH_INFO_*
>      * Have complete functions within an #ifdefs rather than
>        putting #ifdefs in function
>
> Shi Lei (3):
>    util:netlink: Enable virNetlinkNewLink to support veth
>    util:veth: Create veth device pair by netlink
>    lxc: fix a memory leak
>
>   src/lxc/lxc_process.c    |   4 +-
>   src/util/virnetdevveth.c | 126 ++++++++++++++++++++++-----------------
>   src/util/virnetlink.c    |  14 +++++
>   src/util/virnetlink.h    |   1 +
>   4 files changed, 89 insertions(+), 56 deletions(-)
>
Reviewed-by: Laine Stump <laine@redhat.com>


for all 3 (with one tiny change to patch 1 to fix build failure in 
mingw, MacOS and FreeBSD). They're pushed now.


Thanks!