Followup to virNetDevGenerateName() patches

[PATCH 0/5] Followup to virNetDevGenerateName() patches

Laine Stump posted 5 patches 3 years, 4 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201216012723.176100-1-laine@redhat.com

src/bhyve/bhyve_command.c   |  7 ----
src/qemu/qemu_interface.c   | 18 +++--------
src/util/virnetdevmacvlan.c | 64 ++++++-------------------------------
src/util/virnetdevtap.c     | 46 +++++++-------------------
4 files changed, 25 insertions(+), 110 deletions(-)

Expand all Fold all

[PATCH 0/5] Followup to virNetDevGenerateName() patches

Posted by Laine Stump 3 years, 4 months ago

A few issues came up during review of this series that were better
fixed in cleanups rather than requiring yet another round of
review. (A couple of things I noticed after the other patches were
already pushed).

Laine Stump (5):
  util: fix tap device name auto-generation for FreeBSD
  bhyve: remove redundant code that adds "template" netdev name
  qemu: remove redundant code that adds "template" netdev name
  util: simplify virNetDevMacVLanCreateWithVPortProfile()
  util: minor comment/formatting changes to virNetDevTapCreate()

 src/bhyve/bhyve_command.c   |  7 ----
 src/qemu/qemu_interface.c   | 18 +++--------
 src/util/virnetdevmacvlan.c | 64 ++++++-------------------------------
 src/util/virnetdevtap.c     | 46 +++++++-------------------
 4 files changed, 25 insertions(+), 110 deletions(-)

-- 
2.28.0

Re: [PATCH 0/5] Followup to virNetDevGenerateName() patches

Posted by Michal Privoznik 3 years, 4 months ago

On 12/16/20 2:27 AM, Laine Stump wrote:
> A few issues came up during review of this series that were better
> fixed in cleanups rather than requiring yet another round of
> review. (A couple of things I noticed after the other patches were
> already pushed).
> 
> Laine Stump (5):
>    util: fix tap device name auto-generation for FreeBSD
>    bhyve: remove redundant code that adds "template" netdev name
>    qemu: remove redundant code that adds "template" netdev name
>    util: simplify virNetDevMacVLanCreateWithVPortProfile()
>    util: minor comment/formatting changes to virNetDevTapCreate()
> 
>   src/bhyve/bhyve_command.c   |  7 ----
>   src/qemu/qemu_interface.c   | 18 +++--------
>   src/util/virnetdevmacvlan.c | 64 ++++++-------------------------------
>   src/util/virnetdevtap.c     | 46 +++++++-------------------
>   4 files changed, 25 insertions(+), 110 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal