[PATCH] NEWS: add note about virt-ssh-helper perf improvements

Daniel P. Berrangé posted 1 patch 3 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201127100802.1672367-1-berrange@redhat.com
NEWS.rst | 7 +++++++
1 file changed, 7 insertions(+)
[PATCH] NEWS: add note about virt-ssh-helper perf improvements
Posted by Daniel P. Berrangé 3 years, 5 months ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 NEWS.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index aa8a217eb6..8245e34efa 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -44,6 +44,13 @@ v6.10.0 (unreleased)
 
 * **Bug fixes**
 
+  * remote: fixed performance regression in SSH tunnelling
+
+    The virt-ssh-helper binary introduced in 6.9.0 had very
+    poor scalability which impacted libvirt tunnelled migration
+    and storage volume upload/download in particular. It has been
+    updated and now has performance on a par with netcat.
+
 * **Removed features**
 
   * hyperv: removed support for the Hyper-V V1 WMI API
-- 
2.28.0

Re: [PATCH] NEWS: add note about virt-ssh-helper perf improvements
Posted by Andrea Bolognani 3 years, 5 months ago
On Fri, 2020-11-27 at 10:08 +0000, Daniel P. Berrangé wrote:
> +++ b/NEWS.rst
> @@ -44,6 +44,13 @@ v6.10.0 (unreleased)
>  
>  * **Bug fixes**
>  
> +  * remote: fixed performance regression in SSH tunnelling
> +
> +    The virt-ssh-helper binary introduced in 6.9.0 had very

virt-ssh-helper was introduced in 6.8.0, although detection was
broken in that version and so most people only ended up using it
starting with the next release.

You should also put double backticks around ``virt-ssh-helper``.

> +    poor scalability which impacted libvirt tunnelled migration
> +    and storage volume upload/download in particular. It has been
> +    updated and now has performance on a par with netcat.

I believe "on a par", while correct, is much less frequently used
than "on par" so it might look weird to non-native speakers - it
certainly did to me. You might want to change it to the more common
usage.

With at least the version number fixed,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization