[libvirt PATCH v3 00/10] Add missing feature detection to sync tool in cpu_map

Tim Wiederhake posted 10 patches 3 years, 5 months ago
Test syntax-check failed
Failed in applying to current master (apply log)
src/cpu_map/index.xml                         |   1 +
src/cpu_map/meson.build                       |   1 +
src/cpu_map/sync_qemu_i386.py                 | 340 ++++++++++--------
src/cpu_map/x86_Snowridge.xml                 |  71 ++++
src/cpu_map/x86_features.xml                  |  11 +
.../x86_64-cpuid-Ice-Lake-Server-guest.xml    |   1 +
.../x86_64-cpuid-Ice-Lake-Server-host.xml     |   1 +
.../domaincapsdata/qemu_4.1.0-q35.x86_64.xml  |   1 +
.../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml  |   1 +
tests/domaincapsdata/qemu_4.1.0.x86_64.xml    |   1 +
.../domaincapsdata/qemu_4.2.0-q35.x86_64.xml  |   1 +
.../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml  |   1 +
tests/domaincapsdata/qemu_4.2.0.x86_64.xml    |   1 +
.../domaincapsdata/qemu_5.0.0-q35.x86_64.xml  |   1 +
.../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml  |   1 +
tests/domaincapsdata/qemu_5.0.0.x86_64.xml    |   1 +
.../domaincapsdata/qemu_5.1.0-q35.x86_64.xml  |   1 +
.../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml  |   1 +
tests/domaincapsdata/qemu_5.1.0.x86_64.xml    |   1 +
.../domaincapsdata/qemu_5.2.0-q35.x86_64.xml  |   1 +
.../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml  |   1 +
tests/domaincapsdata/qemu_5.2.0.x86_64.xml    |   1 +
22 files changed, 294 insertions(+), 147 deletions(-)
create mode 100644 src/cpu_map/x86_Snowridge.xml
[libvirt PATCH v3 00/10] Add missing feature detection to sync tool in cpu_map
Posted by Tim Wiederhake 3 years, 5 months ago
sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from qemu
with libvirt. It currently has no provisions for detecting new features
that are not implemented in libvirt yet. This series changes that.

Currently missing x86 CPU models:
* "Denverton"
* "KnightsMill"
* "Snowridge"

Currently missing x86 CPU features:
* "core-capability"
* "fsrm"
* "split-lock-detect"

This series adds "core-capability", "fsrm", "split-lock-detect" and the
CPU model for "Snowridge".

V1: https://www.redhat.com/archives/libvir-list/2020-November/msg01002.html
V2: https://www.redhat.com/archives/libvir-list/2020-November/msg01023.html

Tim Wiederhake (10):
  cpu_map: sync_qemu_cpu_i386: Factor out translation of vendors
  cpu_map: sync_qemu_cpu_i386: Factor out translation of features
  cpu_map: sync_qemu_cpu_i386: Translate features in model versions
  cpu_map: sync_qemu_cpu_i386: Simplify ignore features
  cpu_map: sync_qemu_cpu_i386: Add missing features to translation table
  cpu_map: sync_qemu_cpu_i386: Detect features missing in libvirt
  cpu_map: Add support for fsrm CPU feature
  cpu_map: Add support for core-capability CPU feature
  cpu_map: Add support for split-lock-detect CPU feature
  cpu_map: Define and enable Snowridge model

 src/cpu_map/index.xml                         |   1 +
 src/cpu_map/meson.build                       |   1 +
 src/cpu_map/sync_qemu_i386.py                 | 340 ++++++++++--------
 src/cpu_map/x86_Snowridge.xml                 |  71 ++++
 src/cpu_map/x86_features.xml                  |  11 +
 .../x86_64-cpuid-Ice-Lake-Server-guest.xml    |   1 +
 .../x86_64-cpuid-Ice-Lake-Server-host.xml     |   1 +
 .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml  |   1 +
 .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml  |   1 +
 tests/domaincapsdata/qemu_4.1.0.x86_64.xml    |   1 +
 .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml  |   1 +
 .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml  |   1 +
 tests/domaincapsdata/qemu_4.2.0.x86_64.xml    |   1 +
 .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml  |   1 +
 .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml  |   1 +
 tests/domaincapsdata/qemu_5.0.0.x86_64.xml    |   1 +
 .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml  |   1 +
 .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml  |   1 +
 tests/domaincapsdata/qemu_5.1.0.x86_64.xml    |   1 +
 .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml  |   1 +
 .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml  |   1 +
 tests/domaincapsdata/qemu_5.2.0.x86_64.xml    |   1 +
 22 files changed, 294 insertions(+), 147 deletions(-)
 create mode 100644 src/cpu_map/x86_Snowridge.xml

-- 
2.26.2


Re: [libvirt PATCH v3 00/10] Add missing feature detection to sync tool in cpu_map
Posted by Jiri Denemark 3 years, 4 months ago
On Mon, Nov 23, 2020 at 15:14:23 +0100, Tim Wiederhake wrote:
> sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from qemu
> with libvirt. It currently has no provisions for detecting new features
> that are not implemented in libvirt yet. This series changes that.
> 
> Currently missing x86 CPU models:
> * "Denverton"
> * "KnightsMill"
> * "Snowridge"
> 
> Currently missing x86 CPU features:
> * "core-capability"
> * "fsrm"
> * "split-lock-detect"
> 
> This series adds "core-capability", "fsrm", "split-lock-detect" and the
> CPU model for "Snowridge".

Although I acked patches 7 and 8 now, I think it makes sense to push
them with the rest of the Snowridge CPU model (included tests). Feel
free to include the Reviewed-by tags to does patches when resending them
accompanied with the new patches.

Jirka