[libvirt PATCH 00/10] add support for ESP SCSI controller family

Daniel P. Berrangé posted 10 patches 3 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201118173953.576417-1-berrange@redhat.com
docs/formatdomain.rst                         |     3 +-
docs/schemas/domaincommon.rng                 |     3 +
src/conf/domain_conf.c                        |     8 +
src/conf/domain_conf.h                        |     3 +
src/qemu/qemu_alias.c                         |     6 +
src/qemu/qemu_capabilities.c                  |    27 +
src/qemu/qemu_capabilities.h                  |     5 +
src/qemu/qemu_command.c                       |    15 +
src/qemu/qemu_domain.c                        |    21 +
src/qemu/qemu_domain.h                        |     1 +
src/qemu/qemu_domain_address.c                |    10 +
src/qemu/qemu_validate.c                      |    36 +
src/util/virarch.h                            |     3 +
src/vbox/vbox_common.c                        |     3 +
src/vmx/vmx.c                                 |     3 +
tests/domaincapsdata/qemu_5.1.0.sparc.xml     |   101 +
.../caps_1.5.3.x86_64.xml                     |     2 +
.../caps_1.6.0.x86_64.xml                     |     2 +
.../caps_1.7.0.x86_64.xml                     |     2 +
.../caps_2.1.1.x86_64.xml                     |     2 +
.../caps_2.10.0.aarch64.xml                   |     2 +
.../caps_2.10.0.ppc64.xml                     |     2 +
.../caps_2.10.0.x86_64.xml                    |     2 +
.../caps_2.11.0.x86_64.xml                    |     2 +
.../caps_2.12.0.aarch64.xml                   |     2 +
.../caps_2.12.0.ppc64.xml                     |     2 +
.../caps_2.12.0.x86_64.xml                    |     2 +
.../caps_2.4.0.x86_64.xml                     |     2 +
.../caps_2.5.0.x86_64.xml                     |     2 +
.../caps_2.6.0.aarch64.xml                    |     2 +
.../qemucapabilitiesdata/caps_2.6.0.ppc64.xml |     2 +
.../caps_2.6.0.x86_64.xml                     |     2 +
.../caps_2.7.0.x86_64.xml                     |     2 +
.../caps_2.8.0.x86_64.xml                     |     2 +
.../qemucapabilitiesdata/caps_2.9.0.ppc64.xml |     2 +
.../caps_2.9.0.x86_64.xml                     |     2 +
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |     2 +
.../caps_3.0.0.x86_64.xml                     |     2 +
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |     2 +
.../caps_3.1.0.x86_64.xml                     |     2 +
.../caps_4.0.0.aarch64.xml                    |     2 +
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |     2 +
.../caps_4.0.0.riscv32.xml                    |     2 +
.../caps_4.0.0.riscv64.xml                    |     2 +
.../caps_4.0.0.x86_64.xml                     |     2 +
.../caps_4.1.0.x86_64.xml                     |     2 +
.../caps_4.2.0.aarch64.xml                    |     2 +
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |     2 +
.../caps_4.2.0.x86_64.xml                     |     2 +
.../caps_5.0.0.aarch64.xml                    |     2 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |     2 +
.../caps_5.0.0.riscv64.xml                    |     2 +
.../caps_5.0.0.x86_64.xml                     |     2 +
.../caps_5.1.0.sparc.replies                  | 17294 ++++++++++++++++
.../qemucapabilitiesdata/caps_5.1.0.sparc.xml |   133 +
.../caps_5.1.0.x86_64.xml                     |     2 +
.../caps_5.2.0.x86_64.xml                     |     2 +
tests/qemucaps2xmloutdata/caps.sparc.xml      |    25 +
tests/qemuxml2argvdata/sparc-minimal.args     |    34 +
tests/qemuxml2argvdata/sparc-minimal.xml      |    21 +
tests/qemuxml2argvtest.c                      |     3 +
tests/testutilshostcpus.h                     |    10 +
tests/testutilsqemu.c                         |    62 +-
63 files changed, 17882 insertions(+), 26 deletions(-)
create mode 100644 tests/domaincapsdata/qemu_5.1.0.sparc.xml
create mode 100644 tests/qemucapabilitiesdata/caps_5.1.0.sparc.replies
create mode 100644 tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml
create mode 100644 tests/qemucaps2xmloutdata/caps.sparc.xml
create mode 100644 tests/qemuxml2argvdata/sparc-minimal.args
create mode 100644 tests/qemuxml2argvdata/sparc-minimal.xml
[libvirt PATCH 00/10] add support for ESP SCSI controller family
Posted by Daniel P. Berrangé 3 years, 5 months ago
The sparc machines types all have an NCR53C90 SCSI Controller
builtin. This is from the ESP family of SCSI controllers which
includs two PCI variants. Wire up support for all these SCSI
controllers, so we can at least launch a sparc VM with disks
attached. There are likely other gaps in CLI coverage for sparc,
so I don't claim this lets you have a fully working VM yet.

Daniel P. Berrangé (10):
  util: add ARCH_IS_MIPS64 helper macro
  qemu: fix default devices on sparc machines
  qemu: add helper method for checking if ESP SCSI is builtin
  conf: add support for ESP SCSI controller family
  qemu: add capabilities for the three ESP family SCSI controllers
  qemu: enable support for ESP SCSI controller family
  tests: add fake host CPU for sparc architecture
  tests: add capabilities data files for sparc emulator target
  tests: define QEMU driver capabilities for sparc architecture
  tests: add minimal XML example for sparc VM

 docs/formatdomain.rst                         |     3 +-
 docs/schemas/domaincommon.rng                 |     3 +
 src/conf/domain_conf.c                        |     8 +
 src/conf/domain_conf.h                        |     3 +
 src/qemu/qemu_alias.c                         |     6 +
 src/qemu/qemu_capabilities.c                  |    27 +
 src/qemu/qemu_capabilities.h                  |     5 +
 src/qemu/qemu_command.c                       |    15 +
 src/qemu/qemu_domain.c                        |    21 +
 src/qemu/qemu_domain.h                        |     1 +
 src/qemu/qemu_domain_address.c                |    10 +
 src/qemu/qemu_validate.c                      |    36 +
 src/util/virarch.h                            |     3 +
 src/vbox/vbox_common.c                        |     3 +
 src/vmx/vmx.c                                 |     3 +
 tests/domaincapsdata/qemu_5.1.0.sparc.xml     |   101 +
 .../caps_1.5.3.x86_64.xml                     |     2 +
 .../caps_1.6.0.x86_64.xml                     |     2 +
 .../caps_1.7.0.x86_64.xml                     |     2 +
 .../caps_2.1.1.x86_64.xml                     |     2 +
 .../caps_2.10.0.aarch64.xml                   |     2 +
 .../caps_2.10.0.ppc64.xml                     |     2 +
 .../caps_2.10.0.x86_64.xml                    |     2 +
 .../caps_2.11.0.x86_64.xml                    |     2 +
 .../caps_2.12.0.aarch64.xml                   |     2 +
 .../caps_2.12.0.ppc64.xml                     |     2 +
 .../caps_2.12.0.x86_64.xml                    |     2 +
 .../caps_2.4.0.x86_64.xml                     |     2 +
 .../caps_2.5.0.x86_64.xml                     |     2 +
 .../caps_2.6.0.aarch64.xml                    |     2 +
 .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml |     2 +
 .../caps_2.6.0.x86_64.xml                     |     2 +
 .../caps_2.7.0.x86_64.xml                     |     2 +
 .../caps_2.8.0.x86_64.xml                     |     2 +
 .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml |     2 +
 .../caps_2.9.0.x86_64.xml                     |     2 +
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |     2 +
 .../caps_3.0.0.x86_64.xml                     |     2 +
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |     2 +
 .../caps_3.1.0.x86_64.xml                     |     2 +
 .../caps_4.0.0.aarch64.xml                    |     2 +
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |     2 +
 .../caps_4.0.0.riscv32.xml                    |     2 +
 .../caps_4.0.0.riscv64.xml                    |     2 +
 .../caps_4.0.0.x86_64.xml                     |     2 +
 .../caps_4.1.0.x86_64.xml                     |     2 +
 .../caps_4.2.0.aarch64.xml                    |     2 +
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |     2 +
 .../caps_4.2.0.x86_64.xml                     |     2 +
 .../caps_5.0.0.aarch64.xml                    |     2 +
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |     2 +
 .../caps_5.0.0.riscv64.xml                    |     2 +
 .../caps_5.0.0.x86_64.xml                     |     2 +
 .../caps_5.1.0.sparc.replies                  | 17294 ++++++++++++++++
 .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |   133 +
 .../caps_5.1.0.x86_64.xml                     |     2 +
 .../caps_5.2.0.x86_64.xml                     |     2 +
 tests/qemucaps2xmloutdata/caps.sparc.xml      |    25 +
 tests/qemuxml2argvdata/sparc-minimal.args     |    34 +
 tests/qemuxml2argvdata/sparc-minimal.xml      |    21 +
 tests/qemuxml2argvtest.c                      |     3 +
 tests/testutilshostcpus.h                     |    10 +
 tests/testutilsqemu.c                         |    62 +-
 63 files changed, 17882 insertions(+), 26 deletions(-)
 create mode 100644 tests/domaincapsdata/qemu_5.1.0.sparc.xml
 create mode 100644 tests/qemucapabilitiesdata/caps_5.1.0.sparc.replies
 create mode 100644 tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml
 create mode 100644 tests/qemucaps2xmloutdata/caps.sparc.xml
 create mode 100644 tests/qemuxml2argvdata/sparc-minimal.args
 create mode 100644 tests/qemuxml2argvdata/sparc-minimal.xml

-- 
2.28.0


Re: [libvirt PATCH 00/10] add support for ESP SCSI controller family
Posted by Daniel Henrique Barboza 3 years, 5 months ago

On 11/18/20 2:39 PM, Daniel P. Berrangé wrote:
> The sparc machines types all have an NCR53C90 SCSI Controller
> builtin. This is from the ESP family of SCSI controllers which
> includs two PCI variants. Wire up support for all these SCSI
> controllers, so we can at least launch a sparc VM with disks
> attached. There are likely other gaps in CLI coverage for sparc,
> so I don't claim this lets you have a fully working VM yet.
> 
> Daniel P. Berrangé (10):
>    util: add ARCH_IS_MIPS64 helper macro
>    qemu: fix default devices on sparc machines
>    qemu: add helper method for checking if ESP SCSI is builtin
>    conf: add support for ESP SCSI controller family
>    qemu: add capabilities for the three ESP family SCSI controllers
>    qemu: enable support for ESP SCSI controller family
>    tests: add fake host CPU for sparc architecture
>    tests: add capabilities data files for sparc emulator target
>    tests: define QEMU driver capabilities for sparc architecture
>    tests: add minimal XML example for sparc VM


Series LGTM


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


> 
>   docs/formatdomain.rst                         |     3 +-
>   docs/schemas/domaincommon.rng                 |     3 +
>   src/conf/domain_conf.c                        |     8 +
>   src/conf/domain_conf.h                        |     3 +
>   src/qemu/qemu_alias.c                         |     6 +
>   src/qemu/qemu_capabilities.c                  |    27 +
>   src/qemu/qemu_capabilities.h                  |     5 +
>   src/qemu/qemu_command.c                       |    15 +
>   src/qemu/qemu_domain.c                        |    21 +
>   src/qemu/qemu_domain.h                        |     1 +
>   src/qemu/qemu_domain_address.c                |    10 +
>   src/qemu/qemu_validate.c                      |    36 +
>   src/util/virarch.h                            |     3 +
>   src/vbox/vbox_common.c                        |     3 +
>   src/vmx/vmx.c                                 |     3 +
>   tests/domaincapsdata/qemu_5.1.0.sparc.xml     |   101 +
>   .../caps_1.5.3.x86_64.xml                     |     2 +
>   .../caps_1.6.0.x86_64.xml                     |     2 +
>   .../caps_1.7.0.x86_64.xml                     |     2 +
>   .../caps_2.1.1.x86_64.xml                     |     2 +
>   .../caps_2.10.0.aarch64.xml                   |     2 +
>   .../caps_2.10.0.ppc64.xml                     |     2 +
>   .../caps_2.10.0.x86_64.xml                    |     2 +
>   .../caps_2.11.0.x86_64.xml                    |     2 +
>   .../caps_2.12.0.aarch64.xml                   |     2 +
>   .../caps_2.12.0.ppc64.xml                     |     2 +
>   .../caps_2.12.0.x86_64.xml                    |     2 +
>   .../caps_2.4.0.x86_64.xml                     |     2 +
>   .../caps_2.5.0.x86_64.xml                     |     2 +
>   .../caps_2.6.0.aarch64.xml                    |     2 +
>   .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml |     2 +
>   .../caps_2.6.0.x86_64.xml                     |     2 +
>   .../caps_2.7.0.x86_64.xml                     |     2 +
>   .../caps_2.8.0.x86_64.xml                     |     2 +
>   .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml |     2 +
>   .../caps_2.9.0.x86_64.xml                     |     2 +
>   .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |     2 +
>   .../caps_3.0.0.x86_64.xml                     |     2 +
>   .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |     2 +
>   .../caps_3.1.0.x86_64.xml                     |     2 +
>   .../caps_4.0.0.aarch64.xml                    |     2 +
>   .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |     2 +
>   .../caps_4.0.0.riscv32.xml                    |     2 +
>   .../caps_4.0.0.riscv64.xml                    |     2 +
>   .../caps_4.0.0.x86_64.xml                     |     2 +
>   .../caps_4.1.0.x86_64.xml                     |     2 +
>   .../caps_4.2.0.aarch64.xml                    |     2 +
>   .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |     2 +
>   .../caps_4.2.0.x86_64.xml                     |     2 +
>   .../caps_5.0.0.aarch64.xml                    |     2 +
>   .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |     2 +
>   .../caps_5.0.0.riscv64.xml                    |     2 +
>   .../caps_5.0.0.x86_64.xml                     |     2 +
>   .../caps_5.1.0.sparc.replies                  | 17294 ++++++++++++++++
>   .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |   133 +
>   .../caps_5.1.0.x86_64.xml                     |     2 +
>   .../caps_5.2.0.x86_64.xml                     |     2 +
>   tests/qemucaps2xmloutdata/caps.sparc.xml      |    25 +
>   tests/qemuxml2argvdata/sparc-minimal.args     |    34 +
>   tests/qemuxml2argvdata/sparc-minimal.xml      |    21 +
>   tests/qemuxml2argvtest.c                      |     3 +
>   tests/testutilshostcpus.h                     |    10 +
>   tests/testutilsqemu.c                         |    62 +-
>   63 files changed, 17882 insertions(+), 26 deletions(-)
>   create mode 100644 tests/domaincapsdata/qemu_5.1.0.sparc.xml
>   create mode 100644 tests/qemucapabilitiesdata/caps_5.1.0.sparc.replies
>   create mode 100644 tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml
>   create mode 100644 tests/qemucaps2xmloutdata/caps.sparc.xml
>   create mode 100644 tests/qemuxml2argvdata/sparc-minimal.args
>   create mode 100644 tests/qemuxml2argvdata/sparc-minimal.xml
>