[libvirt PATCH] kbase: Shorten "less verbose QEMU logging" example

Andrea Bolognani posted 1 patch 3 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201113153425.650614-1-abologna@redhat.com
docs/kbase/debuglogs.rst | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[libvirt PATCH] kbase: Shorten "less verbose QEMU logging" example
Posted by Andrea Bolognani 3 years, 5 months ago
Rationale for the changes:

  * util.dbus produces very little logging, so it doesn't really
    make sense to filter it out;
  * util.udev doesn't exist;
  * access can be filtered out entirely, as nothing very
    interesting is produced by the only other component in the
    same package (access.accessdriverpolkit).

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 docs/kbase/debuglogs.rst | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/docs/kbase/debuglogs.rst b/docs/kbase/debuglogs.rst
index 7945cf8bed..fed998efd8 100644
--- a/docs/kbase/debuglogs.rst
+++ b/docs/kbase/debuglogs.rst
@@ -178,13 +178,12 @@ Less verbose logging for QEMU VMs
 
 Some subsystems are very noisy and usually not the culprit of the problems. They
 can be silenced individually for a less verbose log while still logging
-everything else. Usual suspects are the JSON code, udev, authentication and such.
+everything else. Usual suspects are the JSON code, RPC, authentication and such.
 A permissive filter is good for development use cases.
 
 ::
 
-    3:remote 4:event 3:util.json 3:util.object 3:util.dbus 3:util.udev 3:node_device 3:rpc 3:access.accessmanager 3:util.netlink 1:*
-
+    3:remote 4:event 3:util.json 3:util.object 3:util.netlink 3:node_device 3:rpc 3:access 1:*
 
 Minimalistic QEMU QMP monitor logging
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- 
2.26.2

Re: [libvirt PATCH] kbase: Shorten "less verbose QEMU logging" example
Posted by Ján Tomko 3 years, 5 months ago
On a Friday in 2020, Andrea Bolognani wrote:
>Rationale for the changes:
>
>  * util.dbus produces very little logging, so it doesn't really
>    make sense to filter it out;
>  * util.udev doesn't exist;
>  * access can be filtered out entirely, as nothing very
>    interesting is produced by the only other component in the
>    same package (access.accessdriverpolkit).
>
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
> docs/kbase/debuglogs.rst | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/docs/kbase/debuglogs.rst b/docs/kbase/debuglogs.rst
>index 7945cf8bed..fed998efd8 100644
>--- a/docs/kbase/debuglogs.rst
>+++ b/docs/kbase/debuglogs.rst
>@@ -178,13 +178,12 @@ Less verbose logging for QEMU VMs
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
Re: [libvirt PATCH] kbase: Shorten "less verbose QEMU logging" example
Posted by Peter Krempa 3 years, 5 months ago
On Fri, Nov 13, 2020 at 16:34:25 +0100, Andrea Bolognani wrote:
> Rationale for the changes:
> 
>   * util.dbus produces very little logging, so it doesn't really
>     make sense to filter it out;

IIRC it did log a lot before the switch to gdbus, thus I'd prefer to
keep this since it's not that long since we switched to gdbus.

>   * util.udev doesn't exist;

I have no idea where I got this though ...

>   * access can be filtered out entirely, as nothing very
>     interesting is produced by the only other component in the
>     same package (access.accessdriverpolkit).
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  docs/kbase/debuglogs.rst | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

If you keep dbus filtered out:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Re: [libvirt PATCH] kbase: Shorten "less verbose QEMU logging" example
Posted by Andrea Bolognani 3 years, 5 months ago
On Fri, 2020-11-13 at 17:09 +0100, Peter Krempa wrote:
> On Fri, Nov 13, 2020 at 16:34:25 +0100, Andrea Bolognani wrote:
> > Rationale for the changes:
> > 
> >   * util.dbus produces very little logging, so it doesn't really
> >     make sense to filter it out;
> 
> IIRC it did log a lot before the switch to gdbus, thus I'd prefer to
> keep this since it's not that long since we switched to gdbus.

Fair enough! Re-added before pushing.

-- 
Andrea Bolognani / Red Hat / Virtualization