more simple g_autoptr() cleanups

[PATCH v1 00/10] more simple g_autoptr() cleanups

Posted by Daniel Henrique Barboza 3 years, 5 months ago

I intended to clean up the virDomainDefFree() calls that I
kept seeing in qemu_driver.c, ended up doing a bit more than
that.

Daniel Henrique Barboza (10):
  qemu_driver.c: use g_autoptr() with virDomainDef pointers
  qemu_driver.c: use g_autoptr() with qemuMigrationParams pointers
  qemu_driver.c: use g_autoptr() with virDomainDeviceDefPtr
  qemu_driver.c: remove unneeded 'cleanup' labels
  qemu_snapshot.c: remove uneeded 'cleanup' label in
    qemuSnapshotDelete()
  qemu_domain.c: use g_autoptr() with virDomainDef pointers
  qemu_domain.c: remove unneeded cleanup labels
  qemu_domain.c: modernize qemuDomainFixupCPUs()
  qemu_domain.c: modernize qemuDomainWriteMasterKeyFile()
  qemu_domain.c: modernize qemuMonitorGetCpuHalted()

 src/qemu/qemu_domain.c   | 100 ++++++------------
 src/qemu/qemu_driver.c   | 219 +++++++++++++++------------------------
 src/qemu/qemu_snapshot.c |   3 +-
 3 files changed, 119 insertions(+), 203 deletions(-)

-- 
2.26.2

Re: [PATCH v1 00/10] more simple g_autoptr() cleanups

Posted by Jonathon Jongsma 3 years, 5 months ago

On Thu, 12 Nov 2020 18:48:30 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:

> I intended to clean up the virDomainDefFree() calls that I
> kept seeing in qemu_driver.c, ended up doing a bit more than
> that.
> 
> Daniel Henrique Barboza (10):
>   qemu_driver.c: use g_autoptr() with virDomainDef pointers
>   qemu_driver.c: use g_autoptr() with qemuMigrationParams pointers
>   qemu_driver.c: use g_autoptr() with virDomainDeviceDefPtr
>   qemu_driver.c: remove unneeded 'cleanup' labels
>   qemu_snapshot.c: remove uneeded 'cleanup' label in
>     qemuSnapshotDelete()
>   qemu_domain.c: use g_autoptr() with virDomainDef pointers
>   qemu_domain.c: remove unneeded cleanup labels
>   qemu_domain.c: modernize qemuDomainFixupCPUs()
>   qemu_domain.c: modernize qemuDomainWriteMasterKeyFile()
>   qemu_domain.c: modernize qemuMonitorGetCpuHalted()
> 
>  src/qemu/qemu_domain.c   | 100 ++++++------------
>  src/qemu/qemu_driver.c   | 219
> +++++++++++++++------------------------ src/qemu/qemu_snapshot.c |
> 3 +- 3 files changed, 119 insertions(+), 203 deletions(-)
> 

Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>

Re: [PATCH v1 00/10] more simple g_autoptr() cleanups

Posted by Daniel Henrique Barboza 3 years, 5 months ago


On 11/12/20 7:21 PM, Jonathon Jongsma wrote:
> On Thu, 12 Nov 2020 18:48:30 -0300
> Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
> 
>> I intended to clean up the virDomainDefFree() calls that I
>> kept seeing in qemu_driver.c, ended up doing a bit more than
>> that.
>>
>> Daniel Henrique Barboza (10):
>>    qemu_driver.c: use g_autoptr() with virDomainDef pointers
>>    qemu_driver.c: use g_autoptr() with qemuMigrationParams pointers
>>    qemu_driver.c: use g_autoptr() with virDomainDeviceDefPtr
>>    qemu_driver.c: remove unneeded 'cleanup' labels
>>    qemu_snapshot.c: remove uneeded 'cleanup' label in
>>      qemuSnapshotDelete()
>>    qemu_domain.c: use g_autoptr() with virDomainDef pointers
>>    qemu_domain.c: remove unneeded cleanup labels
>>    qemu_domain.c: modernize qemuDomainFixupCPUs()
>>    qemu_domain.c: modernize qemuDomainWriteMasterKeyFile()
>>    qemu_domain.c: modernize qemuMonitorGetCpuHalted()
>>
>>   src/qemu/qemu_domain.c   | 100 ++++++------------
>>   src/qemu/qemu_driver.c   | 219
>> +++++++++++++++------------------------ src/qemu/qemu_snapshot.c |
>> 3 +- 3 files changed, 119 insertions(+), 203 deletions(-)
>>
> 
> Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
> 

Pushed. Thanks!


DHB