util: fix insert/instead documentation mixup

[libvirt PATCH] util: fix insert/instead documentation mixup

Jonathon Jongsma posted 1 patch 3 years, 5 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201111211851.3366789-1-jjongsma@redhat.com

src/util/virhash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[libvirt PATCH] util: fix insert/instead documentation mixup

Posted by Jonathon Jongsma 3 years, 5 months ago

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
---
 src/util/virhash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/util/virhash.c b/src/util/virhash.c
index 5d5b6389b5..d105820bfa 100644
--- a/src/util/virhash.c
+++ b/src/util/virhash.c
@@ -147,8 +147,8 @@ virHashFree(GHashTable *table)
  * Add the @userdata to the hash @table. This can later be retrieved
  * by using @name. Duplicate entries generate errors.
  *
- * Deprecated: Consider using g_hash_table_insert insert. Note that
- * g_hash_table_instead doesn't fail if entry exists. Also note that
+ * Deprecated: Consider using g_hash_table_insert instead. Note that
+ * g_hash_table_insert doesn't fail if entry exists. Also note that
  * g_hash_table_insert doesn't copy the key.
  *
  * Returns 0 the addition succeeded and -1 in case of error.
-- 
2.26.2

Re: [libvirt PATCH] util: fix insert/instead documentation mixup

Posted by Jiri Denemark 3 years, 5 months ago

On Wed, Nov 11, 2020 at 15:18:51 -0600, Jonathon Jongsma wrote:
> Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
> ---
>  src/util/virhash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/util/virhash.c b/src/util/virhash.c
> index 5d5b6389b5..d105820bfa 100644
> --- a/src/util/virhash.c
> +++ b/src/util/virhash.c
> @@ -147,8 +147,8 @@ virHashFree(GHashTable *table)
>   * Add the @userdata to the hash @table. This can later be retrieved
>   * by using @name. Duplicate entries generate errors.
>   *
> - * Deprecated: Consider using g_hash_table_insert insert. Note that
> - * g_hash_table_instead doesn't fail if entry exists. Also note that
> + * Deprecated: Consider using g_hash_table_insert instead. Note that
> + * g_hash_table_insert doesn't fail if entry exists. Also note that
>   * g_hash_table_insert doesn't copy the key.
>   *
>   * Returns 0 the addition succeeded and -1 in case of error.

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>