On 11/10/20 10:50 AM, Lin Ma wrote:
> Add more bash completions for some of virsh subcommands/subparameters.
>
> v1->v2
>
> * Follow Michal's suggestions:
> - guestvcpus command: complete offlined vCPUs if --enable, complete onlined vCPUs if --disable
> - Added a static helper function for interface string provider,
> - Adjusted some needlessly complicated loops.
> * Refered to Peter and Michal's comments, I droped the vnc completion patches.
> * Concentrate on completion itself, Drop all of patches which related to macros to make review easier.
>
> Lin Ma (13):
> virsh: Add vcpu list completion to guestvcpus command
> virsh: Add logical CPU IDs completion for nodecpustats command
> virsh: Add serial/parallel device name completion to console command
> virsh-interface: Add a static helper virshInterfaceStringHelper
> virsh: Add interface mac completion to iface-name command
> virsh: Add interface name completion to iface-bridge command
> virsh: Add interface name completion to iface-mac command
> vsh: Fix completion error in case of multiple mac addresses
> virsh: Add mac completion to net-dhcp-leases command
> virsh: Move/add some of function declarations to virsh-domain.h
> virsh: Add signal name completion to send-process-signal command
> virsh: Add lifecycle type completion to set-lifecycle-action command
> Add lifecycle action completion to set-lifecycle-action command
>
> tools/bash-completion/vsh | 1 +
> tools/virsh-completer-domain.c | 190 ++++++++++++++++++++++++++++++
> tools/virsh-completer-domain.h | 20 ++++
> tools/virsh-completer-host.c | 31 +++++
> tools/virsh-completer-host.h | 4 +
> tools/virsh-completer-interface.c | 34 ++++--
> tools/virsh-completer-interface.h | 7 ++
> tools/virsh-completer-network.c | 44 +++++++
> tools/virsh-completer-network.h | 4 +
> tools/virsh-domain.c | 6 +-
> tools/virsh-domain.h | 4 +
> tools/virsh-host.c | 1 +
> tools/virsh-interface.c | 3 +
> tools/virsh-network.c | 15 ++-
> 14 files changed, 349 insertions(+), 15 deletions(-)
>
I've fixed all the small problems I found and
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
and pushed.
Michal