tests: Fix issues on macOS

[PATCH v2 0/3] tests: Fix issues on macOS

Roman Bolshakov posted 3 patches 3 years, 5 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201103142630.81325-1-r.bolshakov@yadro.com

tests/storagepoolxml2argvdata/pool-netfs-gluster.argv | 2 +-
tests/virpcimock.c                                    | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH v2 0/3] tests: Fix issues on macOS

Posted by Roman Bolshakov 3 years, 5 months ago

The series continues effort of fixing libvirt test suite on macOS [1]
and combines previous patches sent a week ago [2][3].

The tests have been fixed:
  qemuhotplugtest
  qemumemlocktest
  qemuxml2xmltest
  storagepoolxml2argvtest

Number of failing tests has been reduced to two:
  qemusecuritytest
  qemuxml2argvtest

Changes since v1:
  - Separated virpcimock patch into two (Andrea)
  - Fixed incorrect test mock data after glusterfs arguments were
    reordered, instead of intruducing darwin-only test data (Andrea)

1. https://gitlab.com/libvirt/libvirt/-/issues/58
2. https://www.redhat.com/archives/libvir-list/2020-October/msg01345.html
3. https://www.redhat.com/archives/libvir-list/2020-October/msg01347.html

Roman Bolshakov (3):
  virpcimock: Initialize real_close before using it
  virpcimock: Enable on macOS
  storagepoolxml2argvtest: Reorder gluster arguments

 tests/storagepoolxml2argvdata/pool-netfs-gluster.argv | 2 +-
 tests/virpcimock.c                                    | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
2.28.0

Re: [PATCH v2 0/3] tests: Fix issues on macOS

Posted by Andrea Bolognani 3 years, 5 months ago

On Tue, 2020-11-03 at 17:26 +0300, Roman Bolshakov wrote:
> The series continues effort of fixing libvirt test suite on macOS [1]
> and combines previous patches sent a week ago [2][3].
> 
> The tests have been fixed:
>   qemuhotplugtest
>   qemumemlocktest
>   qemuxml2xmltest
>   storagepoolxml2argvtest
> 
> Number of failing tests has been reduced to two:
>   qemusecuritytest
>   qemuxml2argvtest
> 
> Changes since v1:
>   - Separated virpcimock patch into two (Andrea)
>   - Fixed incorrect test mock data after glusterfs arguments were
>     reordered, instead of intruducing darwin-only test data (Andrea)
> 
> 1. https://gitlab.com/libvirt/libvirt/-/issues/58
> 2. https://www.redhat.com/archives/libvir-list/2020-October/msg01345.html
> 3. https://www.redhat.com/archives/libvir-list/2020-October/msg01347.html
> 
> Roman Bolshakov (3):
>   virpcimock: Initialize real_close before using it
>   virpcimock: Enable on macOS
>   storagepoolxml2argvtest: Reorder gluster arguments

Series

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and pushed. Thanks!

-- 
Andrea Bolognani / Red Hat / Virtualization