[PATCH] news: Mention Cooperlake cpu model in v6.4.0

Han Han posted 1 patch 3 years, 6 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201028075148.234643-1-hhan@redhat.com
NEWS.rst | 2 ++
1 file changed, 2 insertions(+)
[PATCH] news: Mention Cooperlake cpu model in v6.4.0
Posted by Han Han 3 years, 6 months ago
Signed-off-by: Han Han <hhan@redhat.com>
---
 NEWS.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index 2fef3f706c..5dac805390 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -463,6 +463,8 @@ v6.4.0 (2020-06-02)
     already does in these cases. Users are encouraged to provide complete NUMA
     topologies to avoid unexpected changes in the domain XML.
 
+  * Cooperlake x86 CPU model is added
+
 * **Bug fixes**
 
   * qemu: fixed regression in network device hotplug with new qemu versions
-- 
2.28.0

Re: [PATCH] news: Mention Cooperlake cpu model in v6.4.0
Posted by Martin Kletzander 3 years, 5 months ago
On Wed, Oct 28, 2020 at 03:51:48PM +0800, Han Han wrote:
>Signed-off-by: Han Han <hhan@redhat.com>
>---
> NEWS.rst | 2 ++
> 1 file changed, 2 insertions(+)
>

So yes, this was added in 6.4.0, but I don't know whether we have any policy
regarding news for older releases as that would create inconsistency and there
is always going to be something we missed.  Especially when lot of people do not
update the news file.  On the other hand it would appear in the news file from
now on...  I really don't know.  Does anyone else have an opinion?  @Dan? @Andrea?

>diff --git a/NEWS.rst b/NEWS.rst
>index 2fef3f706c..5dac805390 100644
>--- a/NEWS.rst
>+++ b/NEWS.rst
>@@ -463,6 +463,8 @@ v6.4.0 (2020-06-02)
>     already does in these cases. Users are encouraged to provide complete NUMA
>     topologies to avoid unexpected changes in the domain XML.
>
>+  * Cooperlake x86 CPU model is added
>+
> * **Bug fixes**
>
>   * qemu: fixed regression in network device hotplug with new qemu versions
>-- 
>2.28.0
>
Re: [PATCH] news: Mention Cooperlake cpu model in v6.4.0
Posted by Andrea Bolognani 3 years, 5 months ago
On Fri, 2020-11-06 at 15:10 +0100, Martin Kletzander wrote:
> On Wed, Oct 28, 2020 at 03:51:48PM +0800, Han Han wrote:
> > Signed-off-by: Han Han <hhan@redhat.com>
> > ---
> > NEWS.rst | 2 ++
> > 1 file changed, 2 insertions(+)
> 
> So yes, this was added in 6.4.0, but I don't know whether we have any policy
> regarding news for older releases as that would create inconsistency and there
> is always going to be something we missed.  Especially when lot of people do not
> update the news file.  On the other hand it would appear in the news file from
> now on...  I really don't know.  Does anyone else have an opinion?  @Dan? @Andrea?

I think it can be useful to add this kind of information even after
the fact, since we include the full release notes in release tarballs
as well as publishing them on the website. There is basically no
downside to this, even though of course it would be even better if we
would manage to add this information *before* the release is out :)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH] news: Mention Cooperlake cpu model in v6.4.0
Posted by Martin Kletzander 3 years, 5 months ago
On Fri, Nov 06, 2020 at 03:25:17PM +0100, Andrea Bolognani wrote:
>On Fri, 2020-11-06 at 15:10 +0100, Martin Kletzander wrote:
>> On Wed, Oct 28, 2020 at 03:51:48PM +0800, Han Han wrote:
>> > Signed-off-by: Han Han <hhan@redhat.com>
>> > ---
>> > NEWS.rst | 2 ++
>> > 1 file changed, 2 insertions(+)
>>
>> So yes, this was added in 6.4.0, but I don't know whether we have any policy
>> regarding news for older releases as that would create inconsistency and there
>> is always going to be something we missed.  Especially when lot of people do not
>> update the news file.  On the other hand it would appear in the news file from
>> now on...  I really don't know.  Does anyone else have an opinion?  @Dan? @Andrea?
>
>I think it can be useful to add this kind of information even after
>the fact, since we include the full release notes in release tarballs
>as well as publishing them on the website. There is basically no
>downside to this, even though of course it would be even better if we
>would manage to add this information *before* the release is out :)
>
>Reviewed-by: Andrea Bolognani <abologna@redhat.com>
>

For some reason I thought this was pushed already, but it wasn't.  Anyway, I
pushed it now.

>--
>Andrea Bolognani / Red Hat / Virtualization
>