[PATCH v2] news: introduce memory failure event

zhenwei pi posted 1 patch 3 years, 6 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201023135349.1382259-1-pizhenwei@bytedance.com
NEWS.rst | 10 ++++++++++
1 file changed, 10 insertions(+)
[PATCH v2] news: introduce memory failure event
Posted by zhenwei pi 3 years, 6 months ago
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
---
 NEWS.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index d0454b7840..428928e80b 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -13,6 +13,16 @@ v6.9.0 (unreleased)
 
 * **New features**
 
+  * Introduce memory failure event
+
+    Libvirt could handle domain's memory failure event. Drivers need to
+    implement their own method.
+
+  * qemu: Implement memory failure event
+
+    New event is implemented that is emitted whenever a guest encounters a
+    memory failure.
+
   * qemu: Implement support for ``<transient/>`` disks
 
     VMs based on the QEMU hypervisor now can use ``<transient/>`` option for
-- 
2.11.0

Re: [PATCH v2] news: introduce memory failure event
Posted by Michal Privoznik 3 years, 6 months ago
On 10/23/20 3:53 PM, zhenwei pi wrote:
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
>   NEWS.rst | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index d0454b7840..428928e80b 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -13,6 +13,16 @@ v6.9.0 (unreleased)
>   
>   * **New features**
>   
> +  * Introduce memory failure event
> +
> +    Libvirt could handle domain's memory failure event. Drivers need to
> +    implement their own method.

In my opinion this is unnecessary. The target audience of this file is 
users, not developers so much. Therefore, the second sentence does not 
add much value, because: a) users don't know how to implement that 
(unless an user is also a developer), b) by this time, users should be 
used to our driver model and the fact that some drivers implement a 
feature that other drivers don't (yet).

> +
> +  * qemu: Implement memory failure event
> +
> +    New event is implemented that is emitted whenever a guest encounters a
> +    memory failure.
> +

ACK to this hunk and pushed.

Thanks for handling this.

Michal