[libvirt PATCH v4 4/4] qemu: add docs for 'fmode' and 'dmode' options

Brian Turek posted 4 patches 4 years, 1 month ago
[libvirt PATCH v4 4/4] qemu: add docs for 'fmode' and 'dmode' options
Posted by Brian Turek 4 years, 1 month ago
Adds documentation for QEMU 9pfs 'fmode' and 'dmode' options.

Signed-off-by: Brian Turek <brian.turek@gmail.com>
---
 docs/formatdomain.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index cc4f91d4ea..48a5b821bd 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -3062,6 +3062,12 @@ A directory on the host that can be accessed directly from the guest.
        <target dir='/import/from/host'/>
        <readonly/>
      </filesystem>
+     <filesystem type='mount' accessmode='mapped' fmode='644' dmode='755'>
+       <driver type='path'/>
+       <source dir='/export/to/guest'/>
+       <target dir='/import/from/host'/>
+       <readonly/>
+     </filesystem>
      <filesystem type='file' accessmode='passthrough'>
        <driver type='loop' format='raw'/>
        <source file='/export/to/guest.img'/>
@@ -3140,6 +3146,13 @@ A directory on the host that can be accessed directly from the guest.
    "virtio-non-transitional", or "virtio". See `Virtio transitional
    devices <#elementsVirtioTransitional>`__ for more details.
 
+   The filesystem element has optional attributes ``fmode`` and ``dmode``.
+   These two attributes control the creation mode for files and directories
+   when used with the ``mapped`` value for ``accessmode`` (:since:`since 6.9.0,
+   requires QEMU 2.10` ).  If not specified, QEMU creates files with mode
+   ``600`` and directories with mode ``700``. The setuid, setgid, and sticky
+   bit are unsupported.
+
    The filesystem element has an optional attribute ``multidevs`` which
    specifies how to deal with a filesystem export containing more than one
    device, in order to avoid file ID collisions on guest when using 9pfs (
-- 
2.25.1

Re: [libvirt PATCH v4 4/4] qemu: add docs for 'fmode' and 'dmode' options
Posted by Ján Tomko 4 years ago
On a Thursday in 2020, Brian Turek wrote:
>Adds documentation for QEMU 9pfs 'fmode' and 'dmode' options.
>
>Signed-off-by: Brian Turek <brian.turek@gmail.com>
>---
> docs/formatdomain.rst | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
>index cc4f91d4ea..48a5b821bd 100644
>--- a/docs/formatdomain.rst
>+++ b/docs/formatdomain.rst
>@@ -3062,6 +3062,12 @@ A directory on the host that can be accessed directly from the guest.
>        <target dir='/import/from/host'/>
>        <readonly/>
>      </filesystem>
>+     <filesystem type='mount' accessmode='mapped' fmode='644' dmode='755'>
>+       <driver type='path'/>
>+       <source dir='/export/to/guest'/>
>+       <target dir='/import/from/host'/>
>+       <readonly/>
>+     </filesystem>
>      <filesystem type='file' accessmode='passthrough'>
>        <driver type='loop' format='raw'/>
>        <source file='/export/to/guest.img'/>
>@@ -3140,6 +3146,13 @@ A directory on the host that can be accessed directly from the guest.
>    "virtio-non-transitional", or "virtio". See `Virtio transitional
>    devices <#elementsVirtioTransitional>`__ for more details.
>
>+   The filesystem element has optional attributes ``fmode`` and ``dmode``.
>+   These two attributes control the creation mode for files and directories
>+   when used with the ``mapped`` value for ``accessmode`` (:since:`since 6.9.0,

6.10.0 now

Sadly I did not get to it earlier.

>+   requires QEMU 2.10` ).  If not specified, QEMU creates files with mode
>+   ``600`` and directories with mode ``700``. The setuid, setgid, and sticky
>+   bit are unsupported.
>+
>    The filesystem element has an optional attribute ``multidevs`` which
>    specifies how to deal with a filesystem export containing more than one
>    device, in order to avoid file ID collisions on guest when using 9pfs (

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano