wireshark: Fix missing bool_t on macOS

[PATCH] wireshark: Fix missing bool_t on macOS

Roman Bolshakov posted 1 patch 3 years, 6 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201007122034.9713-1-r.bolshakov@yadro.com

tools/wireshark/src/packet-libvirt.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] wireshark: Fix missing bool_t on macOS

Posted by Roman Bolshakov 3 years, 6 months ago

The header has to be explicitly added to pull definition of bool_t and a
few other types. Otherwise packet-libvirt.c can't be compiled.

Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 tools/wireshark/src/packet-libvirt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c
index 965f1f5482..f43919b05d 100644
--- a/tools/wireshark/src/packet-libvirt.c
+++ b/tools/wireshark/src/packet-libvirt.c
@@ -21,6 +21,7 @@
 #include <wireshark/epan/proto.h>
 #include <wireshark/epan/packet.h>
 #include <wireshark/epan/dissectors/packet-tcp.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
 #include "packet-libvirt.h"
 #include "internal.h"
-- 
2.28.0

Re: [PATCH] wireshark: Fix missing bool_t on macOS

Posted by Andrea Bolognani 3 years, 6 months ago

On Wed, 2020-10-07 at 15:20 +0300, Roman Bolshakov wrote:
> The header has to be explicitly added to pull definition of bool_t and a
> few other types. Otherwise packet-libvirt.c can't be compiled.
> 
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
>  tools/wireshark/src/packet-libvirt.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and pushed.

-- 
Andrea Bolognani / Red Hat / Virtualization