Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
---
 docs/submitting-patches.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst
index 17b072655d..3ce8b347a0 100644
--- a/docs/submitting-patches.rst
+++ b/docs/submitting-patches.rst
@@ -22,7 +22,8 @@ patch. However, the usual workflow of libvirt developer is:
   (hack, committing any changes along the way)
 
 More hints on compiling can be found `here <compiling.html>`__.
-When you want to post your patches:
+Make sure to `sign off <hacking.html#developer-certificate-of-origin>`__
+your commit(s). When you want to post your patches:
 
 ::
 
-- 
2.26.2

On Fri, Oct 02, 2020 at 15:32:48 +0200, Mauro Matteo Cascella wrote:
> Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
> ---
>  docs/submitting-patches.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst
> index 17b072655d..3ce8b347a0 100644
> --- a/docs/submitting-patches.rst
> +++ b/docs/submitting-patches.rst
> @@ -22,7 +22,8 @@ patch. However, the usual workflow of libvirt developer is:
>    (hack, committing any changes along the way)
>  
>  More hints on compiling can be found `here <compiling.html>`__.
> -When you want to post your patches:
> +Make sure to `sign off <hacking.html#developer-certificate-of-origin>`__
> +your commit(s). When you want to post your patches:

IMO this doesn't express the underlying certification of complience
enough.

I'd suggest something like:

Make sure to express your agreement with the 'Developer Certificate of
Origin' <link-here> by adding your 'sign-off'.

On Fri, Oct 2, 2020 at 3:49 PM Peter Krempa <pkrempa@redhat.com> wrote:
>
> On Fri, Oct 02, 2020 at 15:32:48 +0200, Mauro Matteo Cascella wrote:
> > Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
> > ---
> >  docs/submitting-patches.rst | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst
> > index 17b072655d..3ce8b347a0 100644
> > --- a/docs/submitting-patches.rst
> > +++ b/docs/submitting-patches.rst
> > @@ -22,7 +22,8 @@ patch. However, the usual workflow of libvirt developer is:
> >    (hack, committing any changes along the way)
> >
> >  More hints on compiling can be found `here <compiling.html>`__.
> > -When you want to post your patches:
> > +Make sure to `sign off <hacking.html#developer-certificate-of-origin>`__
> > +your commit(s). When you want to post your patches:
>
> IMO this doesn't express the underlying certification of complience
> enough.
>
> I'd suggest something like:
>
> Make sure to express your agreement with the 'Developer Certificate of
> Origin' <link-here> by adding your 'sign-off'.
>

I didn't think too much about the form, just wanted to put a reference
to the DCO paragraph where this is already well explained. That being
said, I agree the sentence could be better rephrased. Will send a new
version of the patch, thanks for your suggestion.

--
Mauro Matteo Cascella, Red Hat Product Security
6F78 E20B 5935 928C F0A8  1A9D 4E55 23B8 BB34 10B0