[PATCH v2 0/4] Add support for QEMU's 'fmode' and 'dmode'

Brian Turek posted 4 patches 3 years, 6 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201002105504.82121-1-brian.turek@gmail.com
docs/formatdomain.rst                         | 12 ++++
docs/schemas/domaincommon.rng                 | 16 +++++
src/conf/domain_conf.c                        | 27 ++++++++
src/conf/domain_conf.h                        |  2 +
src/qemu/qemu_capabilities.c                  |  2 +
src/qemu/qemu_capabilities.h                  |  1 +
src/qemu/qemu_command.c                       |  6 ++
src/qemu/qemu_validate.c                      | 18 ++++++
.../caps_2.10.0.aarch64.xml                   |  1 +
.../caps_2.10.0.ppc64.xml                     |  1 +
.../caps_2.10.0.s390x.xml                     |  1 +
.../caps_2.10.0.x86_64.xml                    |  1 +
.../caps_2.11.0.s390x.xml                     |  1 +
.../caps_2.11.0.x86_64.xml                    |  1 +
.../caps_2.12.0.aarch64.xml                   |  1 +
.../caps_2.12.0.ppc64.xml                     |  1 +
.../caps_2.12.0.s390x.xml                     |  1 +
.../caps_2.12.0.x86_64.xml                    |  1 +
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
.../caps_3.0.0.riscv32.xml                    |  1 +
.../caps_3.0.0.riscv64.xml                    |  1 +
.../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  1 +
.../caps_3.0.0.x86_64.xml                     |  1 +
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
.../caps_3.1.0.x86_64.xml                     |  1 +
.../caps_4.0.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
.../caps_4.0.0.riscv32.xml                    |  1 +
.../caps_4.0.0.riscv64.xml                    |  1 +
.../qemucapabilitiesdata/caps_4.0.0.s390x.xml |  1 +
.../caps_4.0.0.x86_64.xml                     |  1 +
.../caps_4.1.0.x86_64.xml                     |  1 +
.../caps_4.2.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
.../caps_4.2.0.x86_64.xml                     |  1 +
.../caps_5.0.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
.../caps_5.0.0.riscv64.xml                    |  1 +
.../caps_5.0.0.x86_64.xml                     |  1 +
.../caps_5.1.0.x86_64.xml                     |  1 +
.../caps_5.2.0.x86_64.xml                     |  1 +
.../virtio-9p-createmode.x86_64-latest.args   | 45 ++++++++++++++
.../qemuxml2argvdata/virtio-9p-createmode.xml | 58 ++++++++++++++++++
.../virtio-9p-createmode.x86_64-latest.xml    | 61 +++++++++++++++++++
tests/qemuxml2xmltest.c                       |  1 +
46 files changed, 283 insertions(+)
create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.xml
create mode 100644 tests/qemuxml2xmloutdata/virtio-9p-createmode.x86_64-latest.xml
[PATCH v2 0/4] Add support for QEMU's 'fmode' and 'dmode'
Posted by Brian Turek 3 years, 6 months ago
This second version of the patch incorporates Peter Krempa's feedback
by tweaking a few things in the code and, more importantly, splitting
up the singular large patch into smaller patches.

Brian Turek (4):
  qemu: capabilities: add QEMU_CAPS_FSDEV_CREATEMODE
  qemu: add support for 'fmode' and 'dmode' options
  qemu: add schema 'fmode' and 'dmode' options
  qemu: add docs for 'fmode' and 'dmode' options

 docs/formatdomain.rst                         | 12 ++++
 docs/schemas/domaincommon.rng                 | 16 +++++
 src/conf/domain_conf.c                        | 27 ++++++++
 src/conf/domain_conf.h                        |  2 +
 src/qemu/qemu_capabilities.c                  |  2 +
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_command.c                       |  6 ++
 src/qemu/qemu_validate.c                      | 18 ++++++
 .../caps_2.10.0.aarch64.xml                   |  1 +
 .../caps_2.10.0.ppc64.xml                     |  1 +
 .../caps_2.10.0.s390x.xml                     |  1 +
 .../caps_2.10.0.x86_64.xml                    |  1 +
 .../caps_2.11.0.s390x.xml                     |  1 +
 .../caps_2.11.0.x86_64.xml                    |  1 +
 .../caps_2.12.0.aarch64.xml                   |  1 +
 .../caps_2.12.0.ppc64.xml                     |  1 +
 .../caps_2.12.0.s390x.xml                     |  1 +
 .../caps_2.12.0.x86_64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
 .../caps_3.0.0.riscv32.xml                    |  1 +
 .../caps_3.0.0.riscv64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  1 +
 .../caps_3.0.0.x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
 .../caps_3.1.0.x86_64.xml                     |  1 +
 .../caps_4.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
 .../caps_4.0.0.riscv32.xml                    |  1 +
 .../caps_4.0.0.riscv64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.0.0.s390x.xml |  1 +
 .../caps_4.0.0.x86_64.xml                     |  1 +
 .../caps_4.1.0.x86_64.xml                     |  1 +
 .../caps_4.2.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
 .../caps_4.2.0.x86_64.xml                     |  1 +
 .../caps_5.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
 .../caps_5.0.0.riscv64.xml                    |  1 +
 .../caps_5.0.0.x86_64.xml                     |  1 +
 .../caps_5.1.0.x86_64.xml                     |  1 +
 .../caps_5.2.0.x86_64.xml                     |  1 +
 .../virtio-9p-createmode.x86_64-latest.args   | 45 ++++++++++++++
 .../qemuxml2argvdata/virtio-9p-createmode.xml | 58 ++++++++++++++++++
 .../virtio-9p-createmode.x86_64-latest.xml    | 61 +++++++++++++++++++
 tests/qemuxml2xmltest.c                       |  1 +
 46 files changed, 283 insertions(+)
 create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.xml
 create mode 100644 tests/qemuxml2xmloutdata/virtio-9p-createmode.x86_64-latest.xml

-- 
2.25.1

Re: [PATCH v2 0/4] Add support for QEMU's 'fmode' and 'dmode'
Posted by Brian Turek 3 years, 6 months ago
I did some further testing and it appears that QEMU is reading the flags as
base-10 which causes issues. I'll need to make some tweaks and release a v3
of the patches later today.

Please ignore this set.

On Fri, Oct 2, 2020, 11:55 AM Brian Turek <brian.turek@gmail.com> wrote:

> This second version of the patch incorporates Peter Krempa's feedback
> by tweaking a few things in the code and, more importantly, splitting
> up the singular large patch into smaller patches.
>
> Brian Turek (4):
>   qemu: capabilities: add QEMU_CAPS_FSDEV_CREATEMODE
>   qemu: add support for 'fmode' and 'dmode' options
>   qemu: add schema 'fmode' and 'dmode' options
>   qemu: add docs for 'fmode' and 'dmode' options
>
>  docs/formatdomain.rst                         | 12 ++++
>  docs/schemas/domaincommon.rng                 | 16 +++++
>  src/conf/domain_conf.c                        | 27 ++++++++
>  src/conf/domain_conf.h                        |  2 +
>  src/qemu/qemu_capabilities.c                  |  2 +
>  src/qemu/qemu_capabilities.h                  |  1 +
>  src/qemu/qemu_command.c                       |  6 ++
>  src/qemu/qemu_validate.c                      | 18 ++++++
>  .../caps_2.10.0.aarch64.xml                   |  1 +
>  .../caps_2.10.0.ppc64.xml                     |  1 +
>  .../caps_2.10.0.s390x.xml                     |  1 +
>  .../caps_2.10.0.x86_64.xml                    |  1 +
>  .../caps_2.11.0.s390x.xml                     |  1 +
>  .../caps_2.11.0.x86_64.xml                    |  1 +
>  .../caps_2.12.0.aarch64.xml                   |  1 +
>  .../caps_2.12.0.ppc64.xml                     |  1 +
>  .../caps_2.12.0.s390x.xml                     |  1 +
>  .../caps_2.12.0.x86_64.xml                    |  1 +
>  .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
>  .../caps_3.0.0.riscv32.xml                    |  1 +
>  .../caps_3.0.0.riscv64.xml                    |  1 +
>  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  1 +
>  .../caps_3.0.0.x86_64.xml                     |  1 +
>  .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
>  .../caps_3.1.0.x86_64.xml                     |  1 +
>  .../caps_4.0.0.aarch64.xml                    |  1 +
>  .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
>  .../caps_4.0.0.riscv32.xml                    |  1 +
>  .../caps_4.0.0.riscv64.xml                    |  1 +
>  .../qemucapabilitiesdata/caps_4.0.0.s390x.xml |  1 +
>  .../caps_4.0.0.x86_64.xml                     |  1 +
>  .../caps_4.1.0.x86_64.xml                     |  1 +
>  .../caps_4.2.0.aarch64.xml                    |  1 +
>  .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
>  .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
>  .../caps_4.2.0.x86_64.xml                     |  1 +
>  .../caps_5.0.0.aarch64.xml                    |  1 +
>  .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
>  .../caps_5.0.0.riscv64.xml                    |  1 +
>  .../caps_5.0.0.x86_64.xml                     |  1 +
>  .../caps_5.1.0.x86_64.xml                     |  1 +
>  .../caps_5.2.0.x86_64.xml                     |  1 +
>  .../virtio-9p-createmode.x86_64-latest.args   | 45 ++++++++++++++
>  .../qemuxml2argvdata/virtio-9p-createmode.xml | 58 ++++++++++++++++++
>  .../virtio-9p-createmode.x86_64-latest.xml    | 61 +++++++++++++++++++
>  tests/qemuxml2xmltest.c                       |  1 +
>  46 files changed, 283 insertions(+)
>  create mode 100644
> tests/qemuxml2argvdata/virtio-9p-createmode.x86_64-latest.args
>  create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.xml
>  create mode 100644
> tests/qemuxml2xmloutdata/virtio-9p-createmode.x86_64-latest.xml
>
> --
> 2.25.1
>
>