[libvirt PATCH] build: remove old macvtap and virtualport leftovers

Pino Toscano posted 1 patch 3 years, 6 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201002051748.2836527-1-ptoscano@redhat.com
meson.build | 10 ----------
1 file changed, 10 deletions(-)
[libvirt PATCH] build: remove old macvtap and virtualport leftovers
Posted by Pino Toscano 3 years, 6 months ago
Followup of commit a79e7639daffac04b088378e6c79854fcac292f3 and
commit 7556ab139fd2e503ac26ee232ab273f1ec027c21.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
---
 meson.build | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/meson.build b/meson.build
index 257e4452a1..a5ce8e17a8 100644
--- a/meson.build
+++ b/meson.build
@@ -1503,10 +1503,6 @@ elif get_option('firewalld_zone').enabled()
   error('You must have firewalld support enabled to enable firewalld_zone')
 endif
 
-if conf.has('WITH_MACVTAP') and not conf.has('WITH_LIBNL')
-  error('libnl3-devel is required for macvtap support')
-endif
-
 if (pkcheck_prog.found() or get_option('polkit').enabled())
   conf.set('WITH_POLKIT', 1)
 endif
@@ -1515,10 +1511,6 @@ if udev_dep.found() and not pciaccess_dep.found()
   error('You must install the pciaccess module to build with udev')
 endif
 
-if conf.has('WITH_VIRTUALPORT') and not conf.has('WITH_MACVTAP')
-  error('macvtap is required for virtualport support')
-endif
-
 
 # build driver options
 
@@ -2388,7 +2380,6 @@ libs_summary = {
   'libssh': libssh_dep.found(),
   'libssh2': libssh2_dep.found(),
   'libxml': libxml_dep.found(),
-  'macvtap': conf.has('WITH_MACVTAP'),
   'netcf': netcf_dep.found(),
   'NLS': have_gnu_gettext_tools,
   'nss': conf.has('WITH_NSS'),
@@ -2403,7 +2394,6 @@ libs_summary = {
   'sasl': sasl_dep.found(),
   'selinux': selinux_dep.found(),
   'udev': udev_dep.found(),
-  'virtualport': conf.has('WITH_VIRTUALPORT'),
   'xdr': xdr_dep.found(),
   'yajl': yajl_dep.found(),
 }
-- 
2.26.2

Re: [libvirt PATCH] build: remove old macvtap and virtualport leftovers
Posted by Andrea Bolognani 3 years, 6 months ago
On Fri, 2020-10-02 at 07:17 +0200, Pino Toscano wrote:
> Followup of commit a79e7639daffac04b088378e6c79854fcac292f3 and
> commit 7556ab139fd2e503ac26ee232ab273f1ec027c21.

No period at the end of the sentence please, so that copy-and-paste
from a terminal is more convenient.

> Signed-off-by: Pino Toscano <ptoscano@redhat.com>
> ---
>  meson.build | 10 ----------
>  1 file changed, 10 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization